This revision was automatically updated to reflect the committed changes.
Closed by commit rGcdce2fe561eb: [Syntax] Remove delayed folding from tree
building. (authored by hlopko, committed by gribozavr).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/
hlopko added a comment.
I propose adding those tests in a separate patch to keep this one focused.
Those tests are currently failing, because:
- we assume initializer, if present, is extending the declarator range, but
`struct P {} p;` has initializer ending where declarator ended already.
- Un
hlopko updated this revision to Diff 253787.
hlopko marked an inline comment as done.
hlopko added a comment.
Remove unnecessary cast
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D76922/new/
https://reviews.llvm.org/D76922
Files:
clang/lib/Tooli
gribozavr2 accepted this revision.
gribozavr2 added a comment.
This revision is now accepted and ready to land.
Could you add the following tests?
struct Point { int x, y; } point, *pointPtr;
typedef struct Point { int x, y; } PointTy, *PointPtr;
typedef struct { int x, y; } PointTy, *Point
hlopko updated this revision to Diff 253517.
hlopko added a comment.
Rebase
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D76922/new/
https://reviews.llvm.org/D76922
Files:
clang/lib/Tooling/Syntax/BuildTree.cpp
clang/lib/Tooling/Syntax/Tokens.
hlopko updated this revision to Diff 253122.
hlopko added a comment.
Polish
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D76922/new/
https://reviews.llvm.org/D76922
Files:
clang/lib/Tooling/Syntax/BuildTree.cpp
clang/lib/Tooling/Syntax/Tokens.
hlopko updated this revision to Diff 253123.
hlopko added a comment.
Rebase
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D76922/new/
https://reviews.llvm.org/D76922
Files:
clang/lib/Tooling/Syntax/BuildTree.cpp
clang/lib/Tooling/Syntax/Tokens.
hlopko updated this revision to Diff 253108.
hlopko added a comment.
Reformat
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D76922/new/
https://reviews.llvm.org/D76922
Files:
clang/lib/Tooling/Syntax/BuildTree.cpp
clang/lib/Tooling/Syntax/Token
hlopko created this revision.
Herald added a project: clang.
Herald added a subscriber: cfe-commits.
hlopko updated this revision to Diff 253108.
hlopko added a comment.
hlopko edited the summary of this revision.
Reformat
This patch removes delayed folding and replaces it with forward peeking.