[PATCH] D76957: HIP: Merge builtin library handling

arsenm closed this revision. arsenm added a comment. 14e184571139ba4c7347ea547074c6d9ec9c7b14 CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76957/new/ https://reviews.llvm.org/D76957 __

[PATCH] D76957: HIP: Merge builtin library handling

yaxunl accepted this revision. yaxunl added a comment. This revision is now accepted and ready to land. LGTM. Thanks. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76957/new/ https://reviews.llvm.org/D76957 ___ cfe-commits mailing list cfe-

[PATCH] D76957: HIP: Merge builtin library handling

arsenm updated this revision to Diff 258562. arsenm added a comment. Switch default back for correct sqrt. Also add more checks for all of the linked libs, and fix duplicating wave64 logic CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76957/new/ https://reviews.llvm.org/D76957 Files:

[PATCH] D76957: HIP: Merge builtin library handling

yaxunl added inline comments. Comment at: clang/lib/Driver/ToolChains/HIP.cpp:364 +bool FastRelaxedMath = false; +bool CorrectSqrt = false; + By default this was on. We should keep the old behavior. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D

[PATCH] D76957: HIP: Merge builtin library handling

arsenm updated this revision to Diff 257694. arsenm added a comment. Update for new library structure CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76957/new/ https://reviews.llvm.org/D76957 Files: clang/lib/Driver/ToolChains/AMDGPU.cpp clang/lib/Driver/ToolChains/AMDGPU.h clang/

[PATCH] D76957: HIP: Merge builtin library handling

arsenm created this revision. arsenm added reviewers: yaxunl, gregrodgers. Herald added subscribers: kerbowa, Anastasia, nhaehnle, wdng, jvesely. arsenm added parent revisions: D76862: HIP: Ensure new denormal mode attributes are set, D76950: HIP: Link correct denormal mode library, D59321: AMDGPU