ASDenysPetrov updated this revision to Diff 278445.
ASDenysPetrov marked an inline comment as done.
ASDenysPetrov added a comment.
Changed naming due to LLVM rules.
I decided not to change names everywhere to leave the patch more readable.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D77
vsavchenko added a comment.
It is a good practice in many projects to make commit messages into imperative
(i.e. "Improve" instead of "Improving" or "Improved"). Again, not everyone
follows it, but it is good to keep it consistent, right?
@NoQ knock-knock!
Comment at: clang
ASDenysPetrov added a comment.
One more :-)
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D77062/new/
https://reviews.llvm.org/D77062
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe
ASDenysPetrov added a comment.
@NoQ , just one another ping, since it is near to be closed.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D77062/new/
https://reviews.llvm.org/D77062
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
htt
ASDenysPetrov added a comment.
@NoQ gentle ping.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D77062/new/
https://reviews.llvm.org/D77062
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinf
ASDenysPetrov updated this revision to Diff 272997.
ASDenysPetrov added a comment.
@NoQ thanks for the approval. But I'm afraid we should return the check for
`!V.getAs()` back in `CStringChecker::assumeZero`.
Look, I paid attention to the fix for https://llvm.org/PR24951 and related
commit rG4
