[PATCH] D77184: Make it possible for lit.site.cfg to contain relative paths, and use it for llvm and clang

vzakhari added a comment. In D77184#2056306 , @vzakhari wrote: > It does not work on Windows (msbuild) for me, because `${pathlist_escaped}` > contains paths like `%(build_mode)s/bin` (caused by `set_llvm_build_mode`). > This seems to break something so

[PATCH] D77184: Make it possible for lit.site.cfg to contain relative paths, and use it for llvm and clang

vzakhari added a comment. Herald added a project: LLVM. It does not work on Windows (msbuild) for me, because `${pathlist_escaped}` contains paths like `%(build_mode)s/bin` (caused by `set_llvm_build_mode`). This seems to break something so that `python` process does not produce any output at

[PATCH] D77184: Make it possible for lit.site.cfg to contain relative paths, and use it for llvm and clang

andrewng added a comment. In D77184#1960437 , @thakis wrote: > grimar, andrewng: You both have checkout and build on different drives too, > yes? Sorry for not replying earlier. Yes, for most of my setups I have the source checkout on one drive and bui

[PATCH] D77184: Make it possible for lit.site.cfg to contain relative paths, and use it for llvm and clang

grimar added a comment. In D77184#1960437 , @thakis wrote: > grimar, andrewng: You both have checkout and build on different drives too, > yes? Nope. I think my configuration is just normal, except I do not use "C:". My checkout is "D:\Work3\LLVM\llvm-p

[PATCH] D77184: Make it possible for lit.site.cfg to contain relative paths, and use it for llvm and clang

rsmith added a comment. In D77184#1961495 , @thakis wrote: > In D77184#1961220 , @rsmith wrote: > > > In D77184#1961214 , @rsmith wrote: > > > > > In D77184#1961208

[PATCH] D77184: Make it possible for lit.site.cfg to contain relative paths, and use it for llvm and clang

thakis added a comment. > Can you describe your symlink setup in enough detail that I can recreate it > locally please? I've landed a workaround that should make things go for you again in 7db64e202f9 . I'd still be curious

[PATCH] D77184: Make it possible for lit.site.cfg to contain relative paths, and use it for llvm and clang

thakis added a comment. In D77184#1961220 , @rsmith wrote: > In D77184#1961214 , @rsmith wrote: > > > In D77184#1961208 , @rsmith wrote: > > > > > This has broken my ability

[PATCH] D77184: Make it possible for lit.site.cfg to contain relative paths, and use it for llvm and clang

CarlosAlbertoEnciso added a comment. In D77184#1960473 , @thakis wrote: > I pushed Andrew's fix (thanks!) (with minor formatting tweaks) in > dbb0d8ecb3a024bd6817ebd8ad8c5c199a51d933 >

[PATCH] D77184: Make it possible for lit.site.cfg to contain relative paths, and use it for llvm and clang

rsmith added a comment. In D77184#1961214 , @rsmith wrote: > In D77184#1961208 , @rsmith wrote: > > > This has broken my ability to run the `check-clang` target on Linux. There > > are symlinks in the path from whi

[PATCH] D77184: Make it possible for lit.site.cfg to contain relative paths, and use it for llvm and clang

rsmith added a comment. In D77184#1961208 , @rsmith wrote: > This has broken my ability to run the `check-clang` target on Linux. There > are symlinks in the path from which I run my builds, and this patch is > computing incorrect relative paths in that

[PATCH] D77184: Make it possible for lit.site.cfg to contain relative paths, and use it for llvm and clang

rsmith added a comment. This has broken my ability to run the `check-clang` target on Linux. There are symlinks in the path from which I run my builds, and this patch is computing incorrect relative paths in that situation. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION htt

[PATCH] D77184: Make it possible for lit.site.cfg to contain relative paths, and use it for llvm and clang

thakis added a comment. I pushed Andrew's fix (thanks!) (with minor formatting tweaks) in dbb0d8ecb3a024bd6817ebd8ad8c5c199a51d933 . Let me know if you still see issues. Repository: rG LLVM Github Monorepo CHANGES SINCE

[PATCH] D77184: Make it possible for lit.site.cfg to contain relative paths, and use it for llvm and clang

thakis added a comment. grimar, andrewng: You both have checkout and build on different drives too, yes? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77184/new/ https://reviews.llvm.org/D77184 ___ cfe

[PATCH] D77184: Make it possible for lit.site.cfg to contain relative paths, and use it for llvm and clang

grimar added a comment. In D77184#1959351 , @andrewng wrote: > The following patch fixes my issues on Windows, but I haven't tested that it > doesn't break anything else: > > diff --git a/llvm/cmake/modules/AddLLVM.cmake > b/llvm/cmake/modules/AddLLVM.

[PATCH] D77184: Make it possible for lit.site.cfg to contain relative paths, and use it for llvm and clang

andrewng added a comment. The following patch fixes my issues on Windows, but I haven't tested that it doesn't break anything else: diff --git a/llvm/cmake/modules/AddLLVM.cmake b/llvm/cmake/modules/AddLLVM.cmake index 91bec7d8081..f630af211fd 100644 --- a/llvm/cmake/modules/AddLLVM.cmake

[PATCH] D77184: Make it possible for lit.site.cfg to contain relative paths, and use it for llvm and clang

CarlosAlbertoEnciso added a comment. In D77184#1957632 , @thakis wrote: > Thanks! Hi, After the series of changes you have done, I am experiencing a build error on Windows. These are some of the errors: - Attribute ignored -- Loadable modules not s

[PATCH] D77184: Make it possible for lit.site.cfg to contain relative paths, and use it for llvm and clang

This revision was automatically updated to reflect the committed changes. Closed by commit rGfb80b6b2d58c: Make it possible for lit.site.cfg to contain relative paths, and use it for… (authored by thakis). Herald added a project: clang. Herald added a subscriber: cfe-commits. Changed prior to com