This revision was automatically updated to reflect the committed changes.
Closed by commit rGdb71354e4ff1: [ASTMatchers] Fixed CastKind being parsed
incorrectly for dynamic matchers (authored by njames93).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org
aaron.ballman accepted this revision.
aaron.ballman added a comment.
This revision is now accepted and ready to land.
LGTM!
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D77503/new/
https://reviews.llvm.org/D77503
njames93 updated this revision to Diff 256275.
njames93 added a comment.
Added unit test for matcher
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D77503/new/
https://reviews.llvm.org/D77503
Files:
clang/docs/LibASTMatchersReference.html
clang/
aaron.ballman added a comment.
Can you also add some unit tests to the dynamic matcher tests?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D77503/new/
https://reviews.llvm.org/D77503
___
cfe-commits ma
njames93 updated this revision to Diff 256237.
njames93 added a comment.
Fixed up documentation for CastKind matcher.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D77503/new/
https://reviews.llvm.org/D77503
Files:
clang/docs/LibASTMatchersRefere
njames93 updated this revision to Diff 255440.
njames93 added a comment.
- Added support for giving suggestions on invalid inputs
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D77503/new/
https://reviews.llvm.org/D77503
Files:
clang/lib/ASTMatche
njames93 created this revision.
njames93 added a reviewer: klimek.
Herald added a project: clang.
Herald added a subscriber: cfe-commits.
Requires hasCastKind arguments to have `CK_` prefixed to bring it in line with
the documentation and other matchers that take enumerations.
Repository:
rG
