This revision was automatically updated to reflect the committed changes.
Closed by commit rGaede24ecaa08: [PowerPC] Treat 'Z' inline asm
constraint as a true memory constraint (authored by nemanjai).
Changed prior to commit:
https://reviews.llvm.org/D77542?vs=255291&id=265730#toc
Repository:
nemanjai marked an inline comment as done.
nemanjai added inline comments.
Comment at: clang/test/CodeGen/ppc64-inline-asm.c:50
+// CHECK-LABEL: void @testZwOff(i8* %addr, i64 %off)
+// CHEC: %[[VAL:[^ ]+]] = getelementptr i8, i8* %addr, i64 %off
+// CHEC: call void asm sideeffec
stefanp accepted this revision as: stefanp.
stefanp added a comment.
Other than the two missing `K`s in the test case as Amy pointed out LGTM.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D77542/new/
https://reviews.llvm.org/D77542
_
amyk added inline comments.
Comment at: clang/lib/Basic/Targets/PPC.h:277
break;
case 'Q': // Memory operand that is an offset from a register (it is
// usually better to use `m' or `es' in asm statements)
nemanjai wrote:
> amyk wrote:
lei accepted this revision as: lei.
lei added a comment.
This revision is now accepted and ready to land.
LGTM
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D77542/new/
https://reviews.llvm.org/D77542
_
nemanjai marked an inline comment as done.
nemanjai added inline comments.
Comment at: clang/lib/Basic/Targets/PPC.h:277
break;
case 'Q': // Memory operand that is an offset from a register (it is
// usually better to use `m' or `es' in asm statements)
amyk added inline comments.
Comment at: clang/lib/Basic/Targets/PPC.h:277
break;
case 'Q': // Memory operand that is an offset from a register (it is
// usually better to use `m' or `es' in asm statements)
Just curious, but does this ca
nemanjai created this revision.
nemanjai added reviewers: hfinkel, PowerPC.
Herald added subscribers: cfe-commits, shchenz, kbarton.
Herald added a project: clang.
We currently emit incorrect codegen for this constraint because we set it as a
constraint that allows registers. This will cause the
