[PATCH] D77645: [clangd] Support dexp -c "some command"

2020-04-08 Thread Sam McCall via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rG49268a678c2f: [clangd] Support dexp -c "some command" (authored by sammccall). Changed prior to commit: https://reviews.llvm.org/D77645?vs=255660&id=255986#toc Repository: rG LLVM Github Monorepo CH

[PATCH] D77645: [clangd] Support dexp -c "some command"

2020-04-08 Thread Sam McCall via Phabricator via cfe-commits
sammccall marked 4 inline comments as done. sammccall added inline comments. Comment at: clang-tools-extra/clangd/index/dex/dexp/Dexp.cpp:100 +// must do this before opts are destroyed +auto Cleanup = llvm::make_scope_exit(llvm::cl::ResetCommandLineParser); if (Help.

[PATCH] D77645: [clangd] Support dexp -c "some command"

2020-04-08 Thread Kirill Bobyrev via Phabricator via cfe-commits
kbobyrev accepted this revision. kbobyrev added a comment. This revision is now accepted and ready to land. LGTM with a couple of nits Comment at: clang-tools-extra/clangd/index/dex/dexp/Dexp.cpp:85 llvm::cl::ValueDisallowed, llvm::cl::cat(llvm::cl::GeneralCategory)}; +

[PATCH] D77645: [clangd] Support dexp -c "some command"

2020-04-07 Thread Sam McCall via Phabricator via cfe-commits
sammccall created this revision. sammccall added reviewers: mnauw, kbobyrev. Herald added subscribers: cfe-commits, usaxena95, kadircet, arphaman, jkorous, MaskRay, ilya-biryukov. Herald added a project: clang. It runs one command and exits. See D77385 for motiva