[PATCH] D77792: [analyzer] Extend constraint manager to be able to compare simple SymSymExprs

NoQ added inline comments. Comment at: clang/include/clang/StaticAnalyzer/Core/PathSensitive/RangedConstraintManager.h:103-110 + enum class CompareResult { +unknown, +identical, +less, +less_equal, +greater, +greater_equal baloghadamsoft

[PATCH] D77792: [analyzer] Extend constraint manager to be able to compare simple SymSymExprs

vsavchenko added a comment. Hi @baloghadamsoftware Great job! I also wanted to support more operations for range-based logic. However, I don't think that this is the right place to make this kind of assumptions. A couple months ago, I added the `SymbolicRangeInferrer` component to aggregate

[PATCH] D77792: [analyzer] Extend constraint manager to be able to compare simple SymSymExprs

martong added a reviewer: vsavchenko. martong added a comment. Adding Valeriy as a reviewer. He's been working with the solver recently, so his insights might be really useful here. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77792/new/ https://reviews.llvm.org/D77792 __

[PATCH] D77792: [analyzer] Extend constraint manager to be able to compare simple SymSymExprs

baloghadamsoftware updated this revision to Diff 293111. baloghadamsoftware added a comment. Tests updated: some execution paths merged by refactoring assertions. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77792/new/ https://reviews.llvm.org/D77792 Files: clang/include/clang/Stat

[PATCH] D77792: [analyzer] Extend constraint manager to be able to compare simple SymSymExprs

baloghadamsoftware added inline comments. Comment at: clang/include/clang/StaticAnalyzer/Core/PathSensitive/RangedConstraintManager.h:103-110 + enum class CompareResult { +unknown, +identical, +less, +less_equal, +greater, +greater_equal

[PATCH] D77792: [analyzer] Extend constraint manager to be able to compare simple SymSymExprs

baloghadamsoftware added inline comments. Comment at: clang/lib/StaticAnalyzer/Core/RangeConstraintManager.cpp:814 +Optional RangeConstraintManager::tryAssumeSymSymOp( +ProgramStateRef State, BinaryOperator::Opcode Op, SymbolRef LHSSym, NoQ wrote: > I belie

[PATCH] D77792: [analyzer] Extend constraint manager to be able to compare simple SymSymExprs

baloghadamsoftware updated this revision to Diff 292755. baloghadamsoftware added a comment. Crash fixed and new tests added. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77792/new/ https://reviews.llvm.org/D77792 Files: clang/include/clang/StaticAnalyzer/Core/PathSensitive/RangedC

[PATCH] D77792: [analyzer] Extend constraint manager to be able to compare simple SymSymExprs

baloghadamsoftware commandeered this revision. baloghadamsoftware edited reviewers, added: steakhal; removed: baloghadamsoftware. baloghadamsoftware added a comment. Herald added a subscriber: gamesh411. We found use cases which can be solved using this improvement. That is why I commandeer this

[PATCH] D77792: [analyzer] Extend constraint manager to be able to compare simple SymSymExprs

steakhal abandoned this revision. steakhal added a comment. I no longer think that we should support Symbol to Symbol comparisons. It would introduce certain anomalies, like //Why could the CM reason about this and that comparisons wile could not in others//. As of now, it's clear that we can no

[PATCH] D77792: [analyzer] Extend constraint manager to be able to compare simple SymSymExprs

ASDenysPetrov added inline comments. Comment at: clang/include/clang/StaticAnalyzer/Core/PathSensitive/RangedConstraintManager.h:103-110 + enum class CompareResult { +unknown, +identical, +less, +less_equal, +greater, +greater_equal Can

[PATCH] D77792: [analyzer] Extend constraint manager to be able to compare simple SymSymExprs

NoQ added inline comments. Comment at: clang/lib/StaticAnalyzer/Core/RangeConstraintManager.cpp:814 +Optional RangeConstraintManager::tryAssumeSymSymOp( +ProgramStateRef State, BinaryOperator::Opcode Op, SymbolRef LHSSym, I believe you don't need to return

[PATCH] D77792: [analyzer] Extend constraint manager to be able to compare simple SymSymExprs

ASDenysPetrov added a comment. @steakhal What about unsigneds? Does it work for unsigned values as well? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77792/new/ https://reviews.llvm.org/D77792 ___ cfe-commits mailing list cfe-commits@list

Re: [PATCH] D77792: [analyzer] Extend constraint manager to be able to compare simple SymSymExprs

; daniel.kr...@ericsson.com; martongab...@gmail.com; Denis Petrov; cfe-commits@lists.llvm.org; mlek...@skidmore.edu; blitzrak...@gmail.com; shen...@google.com; 1.in...@gmail.com Тема: [PATCH] D77792: [analyzer] Extend constraint manager to be able to compare simple SymSymExprs CAUTION: This email

[PATCH] D77792: [analyzer] Extend constraint manager to be able to compare simple SymSymExprs

steakhal updated this revision to Diff 256551. steakhal added a comment. - rewritten the `RangeSet::compare` function and checked the assumptions on WolframAlpha - moved the `RangeSet::compare` function to a cpp file - added comments to the `RangeSet::compare` function - fixed the comment in `Ran

[PATCH] D77792: [analyzer] Extend constraint manager to be able to compare simple SymSymExprs

steakhal added a comment. In D77792#1971921 , @Szelethus wrote: > You seem to have forgotten `-U` :^) Nice catch! Comment at: clang/lib/StaticAnalyzer/Core/RangeConstraintManager.cpp:774 +Optional RangeConstraintManager::tryAssu

[PATCH] D77792: [analyzer] Extend constraint manager to be able to compare simple SymSymExprs

steakhal updated this revision to Diff 256420. steakhal marked 4 inline comments as done. steakhal added a comment. - add full diff context - NFC refactored `RangeSet` comparison function - add tests for compund `RangeSet`s like: `{[0,1],[5,6]} < {[9,9],[11,42],[44,44]}` - NFC clang-format test f

[PATCH] D77792: [analyzer] Extend constraint manager to be able to compare simple SymSymExprs

martong added a comment. I like it, nice work! Comment at: clang/lib/StaticAnalyzer/Core/RangeConstraintManager.cpp:774 +Optional RangeConstraintManager::tryAssumeSymSymOp( +ProgramStateRef State, BinaryOperator::Opcode Op, SymbolRef LHSSym, Is it possibl

[PATCH] D77792: [analyzer] Extend constraint manager to be able to compare simple SymSymExprs

Szelethus added a comment. You seem to have forgotten `-U` :^) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77792/new/ https://reviews.llvm.org/D77792 ___ cfe-commits mailing list cfe-commits@list

[PATCH] D77792: [analyzer] Extend constraint manager to be able to compare simple SymSymExprs

steakhal created this revision. steakhal added reviewers: NoQ, baloghadamsoftware, Charusso, Szelethus. Herald added subscribers: cfe-commits, ASDenysPetrov, martong, dkrupp, donat.nagy, mikhail.ramalho, a.sidorin, rnkovacs, szepet, xazax.hun, whisperity. Herald added a project: clang. This patch