[PATCH] D77806: [analyzer] Do not report CFError null dereference for nonnull params

2020-06-15 Thread Denys Petrov via Phabricator via cfe-commits
ASDenysPetrov added a comment. @vsavchenko Seems you could fix this bug https://bugs.llvm.org/show_bug.cgi?id=24876 Could you check it, please? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77806/new/ https://reviews.llvm.org/D77806 ___

[PATCH] D77806: [analyzer] Do not report CFError null dereference for nonnull params

2020-04-20 Thread Artem Dergachev via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rG1f67508b7fed: [analyzer] Do not report CFError null dereference for nonnull params. (authored by vsavchenko, committed by dergachev.a). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D77806: [analyzer] Do not report CFError null dereference for nonnull params

2020-04-14 Thread Artem Dergachev via Phabricator via cfe-commits
NoQ accepted this revision. NoQ added a comment. This revision is now accepted and ready to land. Looks great. I'll commit this one as well. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77806/new/ https://reviews.llvm.org/D77806 ___

[PATCH] D77806: [analyzer] Do not report CFError null dereference for nonnull params

2020-04-10 Thread Valeriy Savchenko via Phabricator via cfe-commits
vsavchenko updated this revision to Diff 256530. vsavchenko added a comment. Fix review remarks Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77806/new/ https://reviews.llvm.org/D77806 Files: clang/lib/StaticAnalyzer/Checkers/NonNullParamChecker

[PATCH] D77806: [analyzer] Do not report CFError null dereference for nonnull params

2020-04-10 Thread Valeriy Savchenko via Phabricator via cfe-commits
vsavchenko marked 4 inline comments as done. vsavchenko added a comment. In D77806#1973616 , @NoQ wrote: > We're doing much more here than just fixing the CFError behavior; we're > actually making the whole analyzer respect these annotations in top frame.

[PATCH] D77806: [analyzer] Do not report CFError null dereference for nonnull params

2020-04-09 Thread Artem Dergachev via Phabricator via cfe-commits
NoQ added a comment. We're doing much more here than just fixing the CFError behavior; we're actually making the whole analyzer respect these annotations in top frame. Let's add checker-inspecific tests. We have a test checker `debug.ExprInspection` just for that: // RUN: %clang_analyze_cc1

[PATCH] D77806: [analyzer] Do not report CFError null dereference for nonnull params

2020-04-09 Thread Valeriy Savchenko via Phabricator via cfe-commits
vsavchenko updated this revision to Diff 256331. vsavchenko added a comment. Add extra check to be safe Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77806/new/ https://reviews.llvm.org/D77806 Files: clang/lib/StaticAnalyzer/Checkers/NonNullPara

[PATCH] D77806: [analyzer] Do not report CFError null dereference for nonnull params

2020-04-09 Thread Valeriy Savchenko via Phabricator via cfe-commits
vsavchenko updated this revision to Diff 256318. vsavchenko added a comment. Add forgotten hunk Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77806/new/ https://reviews.llvm.org/D77806 Files: clang/lib/StaticAnalyzer/Checkers/NonNullParamChecker

[PATCH] D77806: [analyzer] Do not report CFError null dereference for nonnull params

2020-04-09 Thread Valeriy Savchenko via Phabricator via cfe-commits
vsavchenko updated this revision to Diff 256306. vsavchenko added a comment. Add one more test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77806/new/ https://reviews.llvm.org/D77806 Files: clang/lib/StaticAnalyzer/Checkers/NonNullParamChecker.

[PATCH] D77806: [analyzer] Do not report CFError null dereference for nonnull params

2020-04-09 Thread Valeriy Savchenko via Phabricator via cfe-commits
vsavchenko created this revision. vsavchenko added reviewers: NoQ, dcoughlin. Herald added subscribers: cfe-commits, ASDenysPetrov, martong, Charusso, dkrupp, donat.nagy, Szelethus, mikhail.ramalho, a.sidorin, JDevlieghere, szepet, baloghadamsoftware, xazax.hun. Herald added a project: clang. We