[PATCH] D77989: Allow disabling of vectorization using internal options

This revision was automatically updated to reflect the committed changes. Closed by commit rG33ffb62e23e7: Allow disabling of vectorization using internal options (authored by tejohnson). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77989/new/ http

[PATCH] D77989: Allow disabling of vectorization using internal options

tejohnson updated this revision to Diff 257562. tejohnson added a comment. Address comment Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77989/new/ https://reviews.llvm.org/D77989 Files: clang/test/CodeGen/thinlto-loop-vectorize-pm.c clang/tes

[PATCH] D77989: Allow disabling of vectorization using internal options

tejohnson marked an inline comment as done. tejohnson added inline comments. Comment at: llvm/lib/Transforms/Vectorize/LoopVectorize.cpp:7618-7621 +: InterleaveOnlyWhenForced(Opts.InterleaveOnlyWhenForced | + !EnableLoopInterleaving), + Vect

[PATCH] D77989: Allow disabling of vectorization using internal options

wmi accepted this revision. wmi added a comment. This revision is now accepted and ready to land. There is a comment about the bitwise operator, otherwise LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77989/new/ https://reviews.llvm.org/D7798

[PATCH] D77989: Allow disabling of vectorization using internal options

tejohnson added a comment. In D77989#1979772 , @wmi wrote: > In D77989#1979725 , @wmi wrote: > > > The patch makes the reasoning about when the internal flags will take > > effect much easier. > > > > One question

[PATCH] D77989: Allow disabling of vectorization using internal options

wmi added a comment. In D77989#1979725 , @wmi wrote: > The patch makes the reasoning about when the internal flags will take effect > much easier. > > One question is, with the change, the internal flags can only be used to > disable loop vectorization/s

[PATCH] D77989: Allow disabling of vectorization using internal options

wmi added a comment. The patch makes the reasoning about when the internal flags will take effect much easier. One question is, with the change, the internal flags can only be used to disable loop vectorization/slp vectorization/loop interleaving, but not to enable them. Can we treat them in t

[PATCH] D77989: Allow disabling of vectorization using internal options

tejohnson created this revision. tejohnson added reviewers: fhahn, wmi. Herald added subscribers: cfe-commits, dexonsmith, steven_wu, hiraditya. Herald added a project: clang. Currently, the internal options -vectorize-loops, -vectorize-slp, and -interleave-loops do not have much practical effect.