[PATCH] D78033: [cmake] Restrict symbols exported from libclang-cpp

2020-04-13 Thread Pirama Arumuga Nainar via Phabricator via cfe-commits
pirama created this revision. pirama added reviewers: beanz, mgorny. Herald added a project: clang. Herald added a subscriber: cfe-commits. In libclang-cpp, export only symbols from the clang namespace or clang_* (functions for the C interface). This fixes the use case where a tool depends on bot

[PATCH] D78033: [cmake] Restrict symbols exported from libclang-cpp

2020-04-13 Thread Chris Bieneman via Phabricator via cfe-commits
beanz added a comment. I think this has some unintended consequences. If your tool wants to use libLLVM and libClang you really need libClang to be linked against libLLVM, otherwise you're actually just hiding the problem. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION http

[PATCH] D78033: [cmake] Restrict symbols exported from libclang-cpp

2020-04-13 Thread Pirama Arumuga Nainar via Phabricator via cfe-commits
pirama added a comment. In D78033#1978612 , @beanz wrote: > I think this has some unintended consequences. If your tool wants to use > libLLVM and libClang you really need libClang to be linked against libLLVM, > otherwise you're actually just hiding the