martong accepted this revision.
martong added a comment.
This revision is now accepted and ready to land.
LG!
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D78099/new/
https://reviews.llvm.org/D78099
___
cfe-commits mailing list
martong requested changes to this revision.
martong added a comment.
This revision now requires changes to proceed.
Found a small mistake that should be corrected, then will be good to me.
Comment at:
Szelethus added a comment.
Ping, @NoQ @vsavchenko I'm confident with the previous patch, but I'd be glad
if one of you could take a look before I land this.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D78099/new/
https://reviews.llvm.org/D78099
Szelethus marked an inline comment as done.
Szelethus added inline comments.
Comment at:
clang/lib/StaticAnalyzer/Checkers/RetainCountChecker/RetainCountChecker.cpp:1500
+RefCountBug::KIND);
+ // TODO: Ideally, we should have a
martong added inline comments.
Comment at:
clang/lib/StaticAnalyzer/Checkers/RetainCountChecker/RetainCountChecker.cpp:1500
+RefCountBug::KIND);
+ // TODO: Ideally, we should have a checker for each of these bug types.
+
