This revision was automatically updated to reflect the committed changes.
Closed by commit rG6529b0c48aab: [clangd] Enable diagnostic fixes within macro
argument expansions. (authored by sammccall).
Changed prior to commit:
https://reviews.llvm.org/D78338?vs=258202&id=258812#toc
Repository:
sammccall marked an inline comment as done.
sammccall added inline comments.
Comment at: clang-tools-extra/clangd/Diagnostics.cpp:563
+for (auto &FixIt : FixIts) {
+ // Allow fixits within a single macro-arg expansion to be applied.
+ if (FixIt.RemoveRange.getBegin(
hokein added inline comments.
Comment at: clang-tools-extra/clangd/Diagnostics.cpp:563
+for (auto &FixIt : FixIts) {
+ // Allow fixits within a single macro-arg expansion to be applied.
+ if (FixIt.RemoveRange.getBegin().isMacroID() &&
sammccall wro
sammccall marked an inline comment as done.
sammccall added inline comments.
Comment at: clang-tools-extra/clangd/Diagnostics.cpp:563
+for (auto &FixIt : FixIts) {
+ // Allow fixits within a single macro-arg expansion to be applied.
+ if (FixIt.RemoveRange.getBegin(
hokein added inline comments.
Comment at: clang-tools-extra/clangd/Diagnostics.cpp:563
+for (auto &FixIt : FixIts) {
+ // Allow fixits within a single macro-arg expansion to be applied.
+ if (FixIt.RemoveRange.getBegin().isMacroID() &&
I feel a bit
sammccall created this revision.
sammccall added a reviewer: hokein.
Herald added subscribers: cfe-commits, usaxena95, kadircet, arphaman, jkorous,
MaskRay, ilya-biryukov.
Herald added a project: clang.
This seems like a pretty safe case, and common enough to be useful.
Repository:
rG LLVM Gi
