This revision was automatically updated to reflect the committed changes.
Closed by commit rG03f419f3eb0c: [SveEmitter] IsInsertOp1SVALL and builtins for
svqdec[bhwd] and svqinc[bhwd] (authored by sdesmalen).
Changed prior to commit:
https://reviews.llvm.org/D78401?vs=259554=260274#toc
sdesmalen updated this revision to Diff 259554.
sdesmalen marked 3 inline comments as done.
sdesmalen added a comment.
- Changed UNSIGNED_BYTE etc from upper-case to CamelCase.
- Added comment explaining need to expand SV_ALL
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D78401/new/
sdesmalen added inline comments.
Comment at: clang/include/clang/Basic/arm_sve.td:530
+class sat_type { string U = u; string T = t; }
+def SIGNED_BYTE : sat_type<"", "c">;
+def SIGNED_HALF : sat_type<"", "s">;
SjoerdMeijer wrote:
> nit: just
SjoerdMeijer accepted this revision.
SjoerdMeijer added a comment.
This revision is now accepted and ready to land.
Looks reasonable
Comment at: clang/include/clang/Basic/arm_sve.td:530
+class sat_type { string U = u; string T = t; }
+def SIGNED_BYTE : sat_type<"",
sdesmalen created this revision.
sdesmalen added reviewers: efriedma, SjoerdMeijer.
Herald added a subscriber: tschuett.
Herald added a project: clang.
sdesmalen added a parent revision: D77597: [SveEmitter] Add IsAppendSVALL and
builtins for svptrue and svcnt[bhwd].
Some ACLE builtins leave out