[PATCH] D78477: [profile] Don't crash when forking in several threads

rovka added a comment. Ping! https://bugs.llvm.org/show_bug.cgi?id=46092 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78477/new/ https://reviews.llvm.org/D78477 ___ cfe-commits mailing list

[PATCH] D78477: [profile] Don't crash when forking in several threads

rovka added a comment. Hi! I think this commit is causing some instability on the 10.0.1 branch on 32-bit arm: https://bugs.llvm.org/show_bug.cgi?id=46092 Can you have a look? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78477/new/

[PATCH] D78477: [profile] Don't crash when forking in several threads

This revision was automatically updated to reflect the committed changes. Closed by commit rGbec223a9bc4e: [profile] Dont crash when forking in several threads (authored by Calixte Denizet calixte.deni...@gmail.com). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D78477: [profile] Don't crash when forking in several threads

calixte updated this revision to Diff 259854. calixte added a comment. Fix nits. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78477/new/ https://reviews.llvm.org/D78477 Files: clang/lib/Driver/ToolChains/Darwin.cpp

[PATCH] D78477: [profile] Don't crash when forking in several threads

serge-sans-paille added inline comments. Comment at: llvm/lib/Transforms/Instrumentation/GCOVProfiling.cpp:697 +Builder.CreateCall(WriteoutF); +if (NextInst != Parent->end()) { + DebugLoc Loc = E->getDebugLoc(); I'm puzzled by this test. ``F`` is a

[PATCH] D78477: [profile] Don't crash when forking in several threads

calixte updated this revision to Diff 258686. calixte added a comment. Herald added a project: clang. Herald added a subscriber: cfe-commits. Export symbol for Darwin target Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78477/new/