[PATCH] D78546: Enable bugprone-argument-comments check in llvm.

2020-05-05 Thread Haojian Wu via Phabricator via cfe-commits
hokein added a comment. In D78546#2005306 , @sammccall wrote: > > LLVM code style encourages this > > Not very strongly, it just says it can be helpful (and tells you how to do it > if you do it). So I'm wary of making it mandatory in cases where it isn't

[PATCH] D78546: Enable bugprone-argument-comments check in llvm.

2020-04-27 Thread Sam McCall via Phabricator via cfe-commits
sammccall added a comment. > LLVM code style encourages this Not very strongly, it just says it can be helpful (and tells you how to do it if you do it). So I'm wary of making it mandatory in cases where it isn't a clear readability win. Had a look at this on clangd code: - the basic no-optio

[PATCH] D78546: Enable bugprone-argument-comments check in llvm.

2020-04-21 Thread Haojian Wu via Phabricator via cfe-commits
hokein created this revision. hokein added a reviewer: sammccall. Herald added subscribers: llvm-commits, aheejin. Herald added a project: LLVM. LLVM code style encourages this [1], this check can detect the missing cases and provide an automatic fixit. [1] https://llvm.org/docs/CodingStandards.h