[PATCH] D78784: [clangd] Add some logging to explain why textual fallback navigation failed

2020-10-26 Thread Nathan Ridge via Phabricator via cfe-commits
nridge abandoned this revision. nridge added a comment. Abandoning as per discussion. Running this locally has led me to propose D90134 . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78784/new/ https://reviews.llv

[PATCH] D78784: [clangd] Add some logging to explain why textual fallback navigation failed

2020-04-25 Thread Nathan Ridge via Phabricator via cfe-commits
nridge added a comment. The intent is to be able to run a production build on a production codebase and see why a particular instance of navigation failed. However, it's not super important that this land; if you don't think it's useful for others, I can just run with it applied locally. Repo

[PATCH] D78784: [clangd] Add some logging to explain why textual fallback navigation failed

2020-04-24 Thread Sam McCall via Phabricator via cfe-commits
sammccall added a comment. This seems fine-grained even for `vlog`. Is this for debugging, can it be `dlog()`? (i.e. available in asserts-enabled builds behind `-debug` or `-debug-only=XRefs.cpp`) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D7878

[PATCH] D78784: [clangd] Add some logging to explain why textual fallback navigation failed

2020-04-23 Thread Nathan Ridge via Phabricator via cfe-commits
nridge created this revision. nridge added a reviewer: sammccall. Herald added subscribers: cfe-commits, usaxena95, kadircet, arphaman, jkorous, MaskRay, ilya-biryukov. Herald added a project: clang. nridge added a comment. Applies on top of D76451 . Depends on

[PATCH] D78784: [clangd] Add some logging to explain why textual fallback navigation failed

2020-04-23 Thread Nathan Ridge via Phabricator via cfe-commits
nridge added a comment. Applies on top of D76451 . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78784/new/ https://reviews.llvm.org/D78784 ___ cfe-commits mailing list