PaulkaToast updated this revision to Diff 260805.
PaulkaToast marked 3 inline comments as done.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D78890/new/
https://reviews.llvm.org/D78890
Files:
clang-tools-extra/clang-tidy/llvmlibc/CMakeLists.txt
PaulkaToast added inline comments.
Comment at: clang-tools-extra/clang-tidy/llvmlibc/CalleeNamespaceCheck.cpp:52-53
+
+ diag(FuncDecl->getLocation(),
+ "currently resolves to: ", clang::DiagnosticIDs::Note);
+}
aaron.ballman wrote:
> PaulkaToast wrote:
> >
This revision was automatically updated to reflect the committed changes.
Closed by commit rG8683f5de5352: [clang-tidy] Add check callee-namespace.
(authored by PaulkaToast).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D78890/new/
https://reviews.l
aaron.ballman accepted this revision.
aaron.ballman added a comment.
This revision is now accepted and ready to land.
LGTM aside from some minor nits.
Comment at: clang-tools-extra/clang-tidy/llvmlibc/CalleeNamespaceCheck.cpp:52-53
+
+ diag(FuncDecl->getLocation(),
+ "cu
PaulkaToast added inline comments.
Comment at: clang-tools-extra/clang-tidy/llvmlibc/CalleeNamespaceCheck.cpp:22-23
+const DeclContext *getOutermostNamespace(const DeclContext *Decl) {
+ if (Decl->isTranslationUnit())
+return Decl;
+ if (Decl->getParent() && Decl->getParent
PaulkaToast updated this revision to Diff 260524.
PaulkaToast marked 8 inline comments as done.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D78890/new/
https://reviews.llvm.org/D78890
Files:
clang-tools-extra/clang-tidy/llvmlibc/CMakeLists.txt
aaron.ballman added inline comments.
Comment at: clang-tools-extra/clang-tidy/llvmlibc/CalleeNamespaceCheck.cpp:22-23
+const DeclContext *getOutermostNamespace(const DeclContext *Decl) {
+ if (Decl->isTranslationUnit())
+return Decl;
+ if (Decl->getParent() && Decl->getPare
PaulkaToast updated this revision to Diff 260218.
PaulkaToast marked 2 inline comments as done.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D78890/new/
https://reviews.llvm.org/D78890
Files:
clang-tools-extra/clang-tidy/llvmlibc/CMakeLists.txt
Eugene.Zelenko added inline comments.
Comment at: clang-tools-extra/docs/ReleaseNotes.rst:119
+
+ Checks all calls resolve to functions within __llvm_libc namespace.
+
Please enclose __llvm_libc in double back-ticks.
Comment at:
clang-tools-e
PaulkaToast created this revision.
PaulkaToast added reviewers: aaron.ballman, njames93.
PaulkaToast added projects: clang-tools-extra, libc-project.
Herald added subscribers: cfe-commits, xazax.hun, mgorny.
Herald added a project: clang.
This check will ensure that all calls to functions resolve
10 matches
Mail list logo