[PATCH] D78982: [clang-format] Fix Microsoft style for enums

curdeius added a comment. In D78982#2013221 , @RKSimon wrote: > @asmith I'm seeing MSVC warnings from this patch: > > E:\llvm\llvm-project\clang\lib\Format\UnwrappedLineParser.cpp(1475): warning > C4305: 'argument': truncation from

[PATCH] D78982: [clang-format] Fix Microsoft style for enums

RKSimon added a comment. @asmith I'm seeing MSVC warnings from this patch: E:\llvm\llvm-project\clang\lib\Format\UnwrappedLineParser.cpp(1475): warning C4305: 'argument': truncation from 'clang::tok::TokenKind' to 'bool' E:\llvm\llvm-project\clang\lib\Format\UnwrappedLineParser.cpp(1828):

[PATCH] D78982: [clang-format] Fix Microsoft style for enums

This revision was automatically updated to reflect the committed changes. Closed by commit rG292058a5d6d7: [clang-format] Fix Microsoft style for enums (authored by asmith). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78982/new/

[PATCH] D78982: [clang-format] Fix Microsoft style for enums

asmith added a comment. In D78982#2012992 , @MyDeveloperDay wrote: > LGTM Thanks for the help! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78982/new/ https://reviews.llvm.org/D78982 ___

[PATCH] D78982: [clang-format] Fix Microsoft style for enums

MyDeveloperDay accepted this revision. MyDeveloperDay added a comment. This revision is now accepted and ready to land. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78982/new/ https://reviews.llvm.org/D78982 ___ cfe-commits mailing

[PATCH] D78982: [clang-format] Fix Microsoft style for enums

asmith updated this revision to Diff 261247. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78982/new/ https://reviews.llvm.org/D78982 Files: clang/docs/ClangFormatStyleOptions.rst clang/include/clang/Format/Format.h clang/lib/Format/Format.cpp

[PATCH] D78982: [clang-format] Fix Microsoft style for enums

asmith updated this revision to Diff 261246. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78982/new/ https://reviews.llvm.org/D78982 Files: clang/docs/ClangFormatStyleOptions.rst clang/include/clang/Format/Format.h clang/lib/Format/Format.cpp

[PATCH] D78982: [clang-format] Fix Microsoft style for enums

asmith updated this revision to Diff 261239. asmith marked an inline comment as done. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78982/new/ https://reviews.llvm.org/D78982 Files: clang/docs/ClangFormatStyleOptions.rst clang/include/clang/Format/Format.h

[PATCH] D78982: [clang-format] Fix Microsoft style for enums

MyDeveloperDay added a comment. You will need to rebase as the non related rst changes have been handled by D79095: [clang-format] NFC Correct clang-format headers file so documentation can be once again autogenerated CHANGES SINCE LAST ACTION

[PATCH] D78982: [clang-format] Fix Microsoft style for enums

MyDeveloperDay requested changes to this revision. MyDeveloperDay added a comment. This revision now requires changes to proceed. Sorry please adjust the patch to remove the un-related changes CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78982/new/ https://reviews.llvm.org/D78982

[PATCH] D78982: [clang-format] Fix Microsoft style for enums

MyDeveloperDay added inline comments. Comment at: clang/lib/Format/Format.cpp:1143 Style.PenaltyReturnTypeOnItsOwnLine = 1000; + Style.AllowShortEnumsOnASingleLine = (Language != FormatStyle::LK_Cpp); Style.AllowShortFunctionsOnASingleLine = FormatStyle::SFS_None;

[PATCH] D78982: [clang-format] Fix Microsoft style for enums

asmith marked 2 inline comments as done. asmith added inline comments. Comment at: clang/lib/Format/Format.cpp:1143 Style.PenaltyReturnTypeOnItsOwnLine = 1000; + Style.AllowShortEnumsOnASingleLine = (Language != FormatStyle::LK_Cpp); Style.AllowShortFunctionsOnASingleLine

[PATCH] D78982: [clang-format] Fix Microsoft style for enums

asmith updated this revision to Diff 260932. asmith retitled this revision from "[clang-format] Fix Microsoft style for C++ enums" to "[clang-format] Fix Microsoft style for enums". asmith edited the summary of this revision. asmith added a comment. Enable for C# CHANGES SINCE LAST ACTION

[PATCH] D78982: [clang-format] Fix Microsoft style for enums

asmith added a comment. In D78982#2007172 , @MyDeveloperDay wrote: > - This needs unit tests in clang/unittests/Format to demonstrate the problem > and test this fixing it Is there an easy way to check the test is working? 'ninja check-clang-format'

[PATCH] D78982: [clang-format] Fix Microsoft style for enums

asmith marked 5 inline comments as done. asmith added inline comments. Comment at: clang/lib/Format/UnwrappedLineParser.cpp:1767 if (FormatTok->Tok.getKind() == ClosingBraceKind) { + if (!Style.AllowEnumsOnASingleLine) +addUnwrappedLine(); This

[PATCH] D78982: [clang-format] Fix Microsoft style for enums

asmith updated this revision to Diff 260732. asmith added a comment. Rename option Add test case Only apply to Microsoft CPP style CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78982/new/ https://reviews.llvm.org/D78982 Files: clang/include/clang/Format/Format.h

[PATCH] D78982: [clang-format] Fix Microsoft style for enums

MyDeveloperDay added inline comments. Comment at: clang/lib/Format/Format.cpp:1143 Style.PenaltyReturnTypeOnItsOwnLine = 1000; + Style.AllowEnumsOnASingleLine = false; Style.AllowShortFunctionsOnASingleLine = FormatStyle::SFS_None; You'll need to fix up

[PATCH] D78982: [clang-format] Fix Microsoft style for enums

MyDeveloperDay added a comment. I think the name should be `AllowShortEnumsOnASingleLine` As once the enum goes over a certain width it will revert to as it was before. enum { EOF, VOID, CHAR, SHORT, DOT, NUMBER, IDENTIFIER } A; vs enum { EOF, VOID, CHAR, SHORT, INT,

[PATCH] D78982: [clang-format] Fix Microsoft style for enums

MyDeveloperDay added a comment. So it doesn't overcome the trailing "," issue. (which is sometimes used to put enums on multiple lines) - (NOTE: maybe it shouldn't) --- Language: Cpp BasedOnStyle: LLVM AllowEnumsOnASingleLine: true enum { B, C, D, } A, B; vs

[PATCH] D78982: [clang-format] Fix Microsoft style for enums

MyDeveloperDay added a comment. Before looking into the merit of the change, it needs a couple of things - This needs unit tests in clang/unittests/Format to demonstrate the problem and test this fixing it - This also needs the ClangStyleOptions.rst file generated with the

[PATCH] D78982: [clang-format] Fix Microsoft style for enums

asmith updated this revision to Diff 260551. asmith added a comment. Fix line breaks like this: enum { a=1, b=2, c=3 } myEnum; which becomes: enum { a=1, b=2, c=3 } myEnum; CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78982/new/ https://reviews.llvm.org/D78982 Files:

[PATCH] D78982: [clang-format] Fix Microsoft style for enums

asmith updated this revision to Diff 260542. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78982/new/ https://reviews.llvm.org/D78982 Files: clang/include/clang/Format/Format.h clang/lib/Format/Format.cpp clang/lib/Format/UnwrappedLineParser.cpp Index:

[PATCH] D78982: [clang-format] Fix Microsoft style for enums

asmith added a comment. This change tries to fix this bug. https://bugs.llvm.org/show_bug.cgi?id=32810 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78982/new/ https://reviews.llvm.org/D78982 ___

[PATCH] D78982: [clang-format] Fix Microsoft style for enums

asmith created this revision. asmith added reviewers: jbcoe, MyDeveloperDay. Herald added a project: clang. Herald added a subscriber: cfe-commits. asmith added a reviewer: thakis. Before this change enums were formatted incorrectly for the Microsoft style. [Original Source] enum {