[PATCH] D79113: Revert "Remove false positive in AvoidNonConstGlobalVariables."

lebedev.ri resigned from this revision. lebedev.ri added a comment. Herald added subscribers: carlosgalvezp, StephenFan. Herald added a reviewer: njames93. Herald added projects: clang-tools-extra, All. This review seems to be stuck/dead, consider abandoning if no longer relevant. Repository:

[PATCH] D79113: Revert "Remove false positive in AvoidNonConstGlobalVariables."

JonasToth added a comment. The issue is resolved now in the CppCoreGuidelines. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79113/new/ https://reviews.llvm.org/D79113 ___ cfe-commits mailing list cfe-co

[PATCH] D79113: Revert "Remove false positive in AvoidNonConstGlobalVariables."

vingeldal added a comment. In D79113#2016294 , @aaron.ballman wrote: > I only see a comment on the issue, but not that the issue was resolved in > favor of that comment (unless I've missed something). If the issue gets > resolved in the direction that c

[PATCH] D79113: Revert "Remove false positive in AvoidNonConstGlobalVariables."

aaron.ballman added a comment. I only see a comment on the issue, but not that the issue was resolved in favor of that comment (unless I've missed something). If the issue gets resolved in the direction that comment is going, then the revert makes sense (though we should add an explicit test ca

[PATCH] D79113: Revert "Remove false positive in AvoidNonConstGlobalVariables."

vingeldal created this revision. Herald added subscribers: cfe-commits, kbarton, nemanjai. Herald added a project: clang. vingeldal added reviewers: aaron.ballman, lebedev.ri, JonasToth, gribozavr2. Herald added a subscriber: wuzish. There was concernes about a false positive in clang-tidy check A