[PATCH] D79201: [clang-format] : Fix additional pointer alignment for overloaded operators

This revision was automatically updated to reflect the committed changes. Closed by commit rGc82243d0675b: [clang-format] : Fix additional pointer alignment for overloaded operators (authored by MyDeveloperDay). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.ll

[PATCH] D79201: [clang-format] : Fix additional pointer alignment for overloaded operators

Abpostelnicu accepted this revision. Abpostelnicu added a comment. This revision is now accepted and ready to land. Sorry, totally forgot about this, thank you! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79201/new/ https://reviews.llvm.org/D79201 __

[PATCH] D79201: [clang-format] : Fix additional pointer alignment for overloaded operators

MyDeveloperDay added a comment. @Abpostelnicu as you requested changes I need an "Accept" from you CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79201/new/ https://reviews.llvm.org/D79201 ___ cfe-commits mailing list cfe-commits@lists.llvm.

[PATCH] D79201: [clang-format] : Fix additional pointer alignment for overloaded operators

sammccall accepted this revision. sammccall added a comment. Sorry, I thought I approved already :-( CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79201/new/ https://reviews.llvm.org/D79201 ___ cfe-commits mailing list cfe-commits@lists.llv

[PATCH] D79201: [clang-format] : Fix additional pointer alignment for overloaded operators

MyDeveloperDay added a comment. gentle ping! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79201/new/ https://reviews.llvm.org/D79201 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cf

[PATCH] D79201: [clang-format] : Fix additional pointer alignment for overloaded operators

MyDeveloperDay updated this revision to Diff 261768. MyDeveloperDay added a comment. Remove extraneous cases CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79201/new/ https://reviews.llvm.org/D79201 Files: clang/lib/Format/TokenAnnotator.cpp clang/unittests/Format/FormatTest.cpp I

[PATCH] D79201: [clang-format] : Fix additional pointer alignment for overloaded operators

Abpostelnicu requested changes to this revision. Abpostelnicu added a comment. This revision now requires changes to proceed. As per what @sammccall said. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79201/new/ https://reviews.llvm.org/D79201 _

[PATCH] D79201: [clang-format] : Fix additional pointer alignment for overloaded operators

sammccall added a comment. Looks OK but covers a lot of cases that can't happen, we should probably not test those at least :-) Comment at: clang/lib/Format/TokenAnnotator.cpp:2817 return false; - if (Right.is(tok::star) && Left.is(tok::star)) + if (Right.isOneOf(tok::s

[PATCH] D79201: [clang-format] : Fix additional pointer alignment for overloaded operators

MyDeveloperDay created this revision. MyDeveloperDay added reviewers: sylvestre.ledru, sammccall, krasimir, Abpostelnicu. MyDeveloperDay added projects: clang, clang-format. Follow on from D78879: [clang-format] [PR45357] Fix issue found with operator spacing to