rjmccall added a comment.
LGTM.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D79631/new/
https://reviews.llvm.org/D79631
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
This revision was not accepted when it landed; it landed in state "Needs
Review".
This revision was automatically updated to reflect the committed changes.
Closed by commit rG7f2db9935009: [PATCH] #pragma float_control should be
permitted in namespace scope. (authored by mibintc).
Repository:
mibintc updated this revision to Diff 263020.
mibintc added a comment.
I corrected the assertion error by propagating usesFPIntrin flag from the
template function to the template instantiation and added a test case. Ready
for review.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST
mibintc added a comment.
No this patch isn't ready yet. i see an assertion if try to instantiate a
template function when the template has enabled floating point settings
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D79631/new/
mibintc created this revision.
mibintc added reviewers: rjmccall, erichkeane.
Herald added a project: clang.
Herald added a subscriber: cfe-commits.
I got a bug report from Intel that https://reviews.llvm.org/D72841 was causing
a crash on Windows in vs2017 header in /std:c++17 mode, because
