[PATCH] D79655: [WebAssembly] Handle exception specifications

thakis added inline comments. Comment at: clang/test/CodeGenCXX/wasm-eh.cpp:387 +// RUN: %clang_cc1 %s -triple wasm32-unknown-unknown -fms-extensions -fexceptions -fcxx-exceptions -fwasm-exceptions -target-feature +exception-handling -emit-llvm -std=c++11 2>&1 | FileCheck %s

[PATCH] D79655: [WebAssembly] Handle exception specifications

aheejin marked an inline comment as done. aheejin added inline comments. Comment at: clang/test/CodeGenCXX/wasm-eh.cpp:387 +// RUN: %clang_cc1 %s -triple wasm32-unknown-unknown -fms-extensions -fexceptions -fcxx-exceptions -fwasm-exceptions -target-feature +exception-handling

[PATCH] D79655: [WebAssembly] Handle exception specifications

aheejin added a comment. This is very strange. I haven't committed a file called wasm-eh.ll. (There is a file called wasm-eh.cpp, which existed for more than a year now.) Also there's no wasm-eh.ll in LLVM repo now either. I wonder how this happened..? Also I can't reproduce the bug in my local

[PATCH] D79655: [WebAssembly] Handle exception specifications

thakis added a comment. The revert broke check-clang on several bots, e.g. here http://lab.llvm.org:8011/builders/clang-ppc64be-linux-lnt/builds/38159 Can you take a look please? The tree's been red all of today due to this. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION ht

[PATCH] D79655: [WebAssembly] Handle exception specifications

aheejin added a comment. Committed and reverted this. Resubmitted this in D80061 . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79655/new/ https://reviews.llvm.org/D79655 ___

[PATCH] D79655: [WebAssembly] Handle exception specifications

This revision was automatically updated to reflect the committed changes. Closed by commit rGbca347508c86: [WebAssembly] Handle exception specifications (authored by aheejin). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79655/new/ https://reviews.

[PATCH] D79655: [WebAssembly] Handle exception specifications

aheejin marked an inline comment as done. aheejin added inline comments. Comment at: clang/test/CodeGenCXX/wasm-eh.cpp:399 +// RUN: %clang_cc1 %s -triple wasm32-unknown-unknown -fms-extensions -fexceptions -fcxx-exceptions -fwasm-exceptions -target-feature +exception-handling

[PATCH] D79655: [WebAssembly] Handle exception specifications

dschuff accepted this revision. dschuff added inline comments. This revision is now accepted and ready to land. Comment at: clang/test/CodeGenCXX/wasm-eh.cpp:399 +// RUN: %clang_cc1 %s -triple wasm32-unknown-unknown -fms-extensions -fexceptions -fcxx-exceptions -fwasm-exceptio

[PATCH] D79655: [WebAssembly] Handle exception specifications

aheejin updated this revision to Diff 264335. aheejin added a comment. Handle `throw()` in the same way as `noexcept` Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79655/new/ https://reviews.llvm.org/D79655 Files: clang/include/clang/Basic/Diagn

[PATCH] D79655: [WebAssembly] Handle exception specifications

aheejin added a comment. Now this handles `throw()` in the same way as `noexcept`, and prints a warning only in case of `throw(type, ..)`, as you suggested. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79655/new/ https://reviews.llvm.org/D79655