This revision was automatically updated to reflect the committed changes.
Closed by commit rG80e15b4574f4: [Clang][OpenMP][OMPBuilder] Moving OMP
allocation and cache creation code to… (authored by fghanim).
Changed prior to commit:
https://reviews.llvm.org/D79676?vs=269584&id=273983#toc
Repos
fghanim updated this revision to Diff 269584.
fghanim added a comment.
Herald added a subscriber: sstefan1.
- rebase
- addressing reviewer's comments
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D79676/new/
https://reviews.llvm.org/D79676
Files:
jdoerfert accepted this revision.
jdoerfert added a comment.
This revision is now accepted and ready to land.
Interesting that no tests changed but I guess we just start the move to the
IRBUilder.
I think there are two minor comments from before that need to be addressed and
the alloca thing, o
fghanim marked 4 inline comments as done.
fghanim added inline comments.
Comment at: clang/lib/CodeGen/CGStmtOpenMP.cpp:878
+ [this, VDInit, OriginalAddr, VD, ThisFirstprivateIsLastprivate,
+ OrigVD, &Lastprivates, IRef, &OMPBuilder]() {
fghanim updated this revision to Diff 264012.
fghanim marked an inline comment as done.
fghanim added a comment.
updating in response to review comments
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D79676/new/
https://reviews.llvm.org/D79676
Files
jdoerfert added inline comments.
Comment at: clang/lib/CodeGen/CGStmtOpenMP.cpp:878
+ [this, VDInit, OriginalAddr, VD, ThisFirstprivateIsLastprivate,
+ OrigVD, &Lastprivates, IRef, &OMPBuilder]() {
// Emit private VarDecl with copy init
fghanim created this revision.
fghanim added a reviewer: jdoerfert.
Herald added subscribers: cfe-commits, guansong, yaxunl.
Herald added a project: clang.
Modified the OMPBuilderCBHelpers in the following ways:
- Moved location of class definition and deleted all constructors
- Moved OpenMP-spec
