[PATCH] D79677: [clang][OpenMP][OMPIRBuilder] Adding some Privatization clauses to OpenMP `parallel` Directive

2020-06-09 Thread Fady Ghanim via Phabricator via cfe-commits
fghanim added a comment. @jdoerfert Please suggest reviewer's for this, and I will add them to other clang related patches Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79677/new/ https://reviews.llvm.org/D79677

[PATCH] D79677: [clang][OpenMP][OMPIRBuilder] Adding some Privatization clauses to OpenMP `parallel` Directive

2020-06-09 Thread Fady Ghanim via Phabricator via cfe-commits
fghanim updated this revision to Diff 269589. fghanim added a comment. Herald added subscribers: aaron.ballman, sstefan1. - rebase - splitting patch into 4 ( this, D81482 , D81483 , D81484 ) - a

[PATCH] D79677: [clang][OpenMP][OMPIRBuilder] Adding some Privatization clauses to OpenMP `parallel` Directive

2020-05-14 Thread Fady Ghanim via Phabricator via cfe-commits
fghanim marked 2 inline comments as done. fghanim added a comment. In D79677#2032942 , @jdoerfert wrote: > Generally you copied the existing Clang logic, correct? Well, Yes and no. I tried to keep as much as I can of the original implementation, however

[PATCH] D79677: [clang][OpenMP][OMPIRBuilder] Adding some Privatization clauses to OpenMP `parallel` Directive

2020-05-12 Thread Johannes Doerfert via Phabricator via cfe-commits
jdoerfert added a comment. Generally you copied the existing Clang logic, correct? Comment at: clang/lib/CodeGen/CGStmtOpenMP.cpp:803 - OrigVD); -else - (void)CGM.getOpenMPRuntime().registerTa

[PATCH] D79677: [clang][OpenMP][OMPIRBuilder] Adding some Privatization clauses to OpenMP `parallel` Directive

2020-05-09 Thread Fady Ghanim via Phabricator via cfe-commits
fghanim created this revision. fghanim added a reviewer: jdoerfert. Herald added subscribers: cfe-commits, guansong, yaxunl. Herald added a project: clang. fghanim added a parent revision: D79676: [Clang][OpenMP][OMPBuilder] Moving OMP allocation and cache creation code to OMPBuilderCBHelpers. -