[PATCH] D79698: Run Coverage pass before other *San passes under new pass manager

leonardchan added a comment. In D79698#2037425 , @aeubanks wrote: > In D79698#2037305 , @leonardchan > wrote: > > > Just to followup on this: We believe the root cause of the error we're > > running into is that s

[PATCH] D79698: Run Coverage pass before other *San passes under new pass manager

aeubanks added a comment. In D79698#2037305 , @leonardchan wrote: > Just to followup on this: We believe the root cause of the error we're > running into is that some sancov guards in one comdat are being referenced by > symbols in another comdat, so due

[PATCH] D79698: Run Coverage pass before other *San passes under new pass manager

leonardchan added a comment. Just to followup on this: We believe the root cause of the error we're running into is that some sancov guards in one comdat are being referenced by symbols in another comdat, so due to linking order, the other comdat in question is referencing a sancov guard that w

[PATCH] D79698: Run Coverage pass before other *San passes under new pass manager

leonardchan added a comment. This patch seems to lead to the undefined symbol error we're seeing when building fuchsia: ld.lld: error: relocation refers to a discarded section: __sancov_guards >>> defined in user-x64-sancov.shlib/obj/third_party/ulib/scudo/scudo.string_utils.cc.o >>> refe

[PATCH] D79698: Run Coverage pass before other *San passes under new pass manager

This revision was automatically updated to reflect the committed changes. Closed by commit rG7d5bb94d7838: Run Coverage pass before other *San passes under new pass manager (authored by aeubanks). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79698/n

[PATCH] D79698: Run Coverage pass before other *San passes under new pass manager

leonardchan accepted this revision. leonardchan added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79698/new/ https://reviews.llvm.org/D79698 _

[PATCH] D79698: Run Coverage pass before other *San passes under new pass manager

aeubanks created this revision. aeubanks added reviewers: vitalybuka, leonardchan. Herald added a project: clang. Herald added a subscriber: cfe-commits. This fixes compiler-rt/test/msan/coverage-levels.cpp under the new pass manager (final check-msan test!). Under the old pass manager, the cover