[PATCH] D79800: [Sema] Implement DR2233

tambre abandoned this revision. tambre added a comment. In D79800#2058985 , @rsmith wrote: > Unfortunately, I think this approach basically can't work, because we need to > consider inheriting default arguments from a previous (or subsequent!) >

[PATCH] D79800: [Sema] Implement DR2233

rsmith added a comment. Unfortunately, I think this approach basically can't work, because we need to consider inheriting default arguments from a previous (or subsequent!) declaration before dropping default arguments preceding a pack. I think we will instead need to detect this situation

[PATCH] D79800: [Sema] Implement DR2233

rjmccall added a comment. A couple of minor requests. Otherwise this looks good to me, although I really would like @rsmith to sign off on this approach, especially given his involvement with the DRs. Comment at: clang/lib/Sema/SemaTemplateInstantiateDecl.cpp:1985 +//

[PATCH] D79800: [Sema] Implement DR2233

tambre updated this revision to Diff 265855. tambre marked an inline comment as done. tambre added a comment. Improve comment Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79800/new/ https://reviews.llvm.org/D79800 Files:

[PATCH] D79800: [Sema] Implement DR2233

tambre added a comment. Thanks for the reviews! I believe this now handles all cases and with this we're standards-conforming in regard to DR777 and DR2233. Comment at: clang/lib/Sema/SemaTemplateInstantiateDecl.cpp:1987 + +if (Function->getNumParams() >=