[PATCH] D7982: Add readability-duplicate-include check to clang-tidy

Eugene.Zelenko added a comment. Functionality-wise this check is superseded by Include What You Use . Comment at: clang-tools-extra/docs/clang-tidy/checks/readability-duplicate-include.rst:6 + +Looks for duplicate

[PATCH] D7982: Add readability-duplicate-include check to clang-tidy

LegalizeAdulthood updated this revision to Diff 396932. LegalizeAdulthood added a comment. Herald added a subscriber: carlosgalvezp. Herald added a project: clang-tools-extra. Revive review with updated diff on top-of-tree Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D7982: Add readability-duplicate-include check to clang-tidy

LegalizeAdulthood abandoned this revision. LegalizeAdulthood added a comment. Herald added subscribers: jdoerfert, mgorny. Review takes too long to make forward progress; abandoning. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D7982/new/ https://reviews.llvm.org/D7982

Re: [PATCH] D7982: Add readability-duplicate-include check to clang-tidy

Eugene.Zelenko added a subscriber: Eugene.Zelenko. Eugene.Zelenko added a comment. Include What You Use detect duplicated include directives. I think will be good idea to use it instead of Clang-tidy for much deeper analysis. http://reviews.llvm.org/D7982

Re: [PATCH] D7982: Add readability-duplicate-include check to clang-tidy

LegalizeAdulthood added inline comments. Comment at: clang-tidy/readability/DuplicateIncludeCheck.cpp:62 @@ +61,3 @@ +StringRef SearchPath, StringRef RelativePath, const Module *Imported) { + if (!SM_.isInMainFile(HashLoc)) { +return; LegalizeAdulthood

Re: [PATCH] D7982: Add readability-duplicate-include check to clang-tidy

LegalizeAdulthood added a comment. I need to update from review comments and upload a new diff. http://reviews.llvm.org/D7982 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D7982: Add readability-duplicate-include check to clang-tidy

alexfh added a comment. What's the state of this patch? http://reviews.llvm.org/D7982 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits