[PATCH] D79852: [libunwind] Fix wrong endianness check in Unwind-EHABI

2020-05-29 Thread Saleem Abdulrasool via Phabricator via cfe-commits
compnerd closed this revision. compnerd added a comment. Merged as rG68c50708d1f2b9aee3f10ec710df0b1387f701e5 . Thanks for the portability fix! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D79852: [libunwind] Fix wrong endianness check in Unwind-EHABI

2020-05-29 Thread Saleem Abdulrasool via Phabricator via cfe-commits
compnerd accepted this revision. compnerd added a comment. This seems fine with the minor thing that the original check was not incorrect, merely not as portable, `__BYTE_ORDER__` is more portable. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D79852: [libunwind] Fix wrong endianness check in Unwind-EHABI

2020-05-27 Thread Idan Freiberg via Phabricator via cfe-commits
speidy accepted this revision. speidy added a comment. Can you merge? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79852/new/ https://reviews.llvm.org/D79852 ___ cfe-commits mailing list

[PATCH] D79852: [libunwind] Fix wrong endianness check in Unwind-EHABI

2020-05-13 Thread Martin Storsjö via Phabricator via cfe-commits
mstorsjo accepted this revision. mstorsjo added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79852/new/ https://reviews.llvm.org/D79852

[PATCH] D79852: [libunwind] Fix wrong endianness check in Unwind-EHABI

2020-05-13 Thread Idan Freiberg via Phabricator via cfe-commits
speidy created this revision. speidy added a reviewer: miyuki. speidy added a project: libunwind. Herald added subscribers: libcxx-commits, llvm-commits, kristof.beyls. Herald added a project: LLVM. Herald added a reviewer: libunwind. speidy edited the summary of this revision. speidy edited the