[PATCH] D79910: [x86][seses] Add clang flag; Use lvi-cfi with seses

This revision was automatically updated to reflect the committed changes. Closed by commit rG9d9e499840af: [x86][seses] Add clang flag; Use lvi-cfi with seses (authored by zbrid). Herald added a subscriber: jfb. Changed prior to commit: https://reviews.llvm.org/D79910?vs=272117=275687#toc

[PATCH] D79910: [x86][seses] Add clang flag; Use lvi-cfi with seses

This revision was automatically updated to reflect the committed changes. Closed by commit rG9d9e499840af: [x86][seses] Add clang flag; Use lvi-cfi with seses (authored by zbrid). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79910/new/

[PATCH] D79910: [x86][seses] Add clang flag; Use lvi-cfi with seses

zbrid updated this revision to Diff 276196. zbrid added a comment. rebase prior to commit Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79910/new/ https://reviews.llvm.org/D79910 Files: clang/docs/ClangCommandLineReference.rst

[PATCH] D79910: [x86][seses] Add clang flag; Use lvi-cfi with seses

zbrid updated this revision to Diff 276153. zbrid added a comment. Herald added a subscriber: jfb. update seses flag Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79910/new/ https://reviews.llvm.org/D79910 Files:

[PATCH] D79910: [x86][seses] Add clang flag; Use lvi-cfi with seses

zbrid updated this revision to Diff 276147. zbrid added a comment. rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79910/new/ https://reviews.llvm.org/D79910 Files: clang/docs/ClangCommandLineReference.rst

[PATCH] D79910: [x86][seses] Add clang flag; Use lvi-cfi with seses

craig.topper added inline comments. Comment at: clang/lib/Driver/ToolChains/Arch/X86.cpp:200 +if (!Args.hasArg(options::OPT_mno_lvi_cfi)) { + Features.push_back("+lvi-cfi"); + LVIOpt = options::OPT_mlvi_cfi; sconstab wrote: > zbrid wrote: > >

[PATCH] D79910: [x86][seses] Add clang flag; Use lvi-cfi with seses

sconstab accepted this revision. sconstab added a comment. This revision is now accepted and ready to land. LGTM. Comment at: clang/lib/Driver/ToolChains/Arch/X86.cpp:200 +if (!Args.hasArg(options::OPT_mno_lvi_cfi)) { + Features.push_back("+lvi-cfi"); + LVIOpt =

[PATCH] D79910: [x86][seses] Add clang flag; Use lvi-cfi with seses

zbrid added a comment. @sconstab @craig.topper - Ping for review Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79910/new/ https://reviews.llvm.org/D79910 ___ cfe-commits mailing list

[PATCH] D79910: [x86][seses] Add clang flag; Use lvi-cfi with seses

zbrid marked 2 inline comments as done. zbrid added inline comments. Comment at: clang/include/clang/Driver/Options.td:2244 HelpText<"Disable control-flow mitigations for Load Value Injection (LVI)">; +def m_seses : Flag<["-"], "mseses">, Group, Flags<[CoreOption,

[PATCH] D79910: [x86][seses] Add clang flag; Use lvi-cfi with seses

MaskRay added inline comments. Comment at: clang/include/clang/Driver/Options.td:2244 HelpText<"Disable control-flow mitigations for Load Value Injection (LVI)">; +def m_seses : Flag<["-"], "mseses">, Group, Flags<[CoreOption, DriverOption]>, + HelpText<"Enable speculative

[PATCH] D79910: [x86][seses] Add clang flag; Use lvi-cfi with seses

zbrid updated this revision to Diff 272117. zbrid added a comment. Fix accidentally deleted clang command line ref Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79910/new/ https://reviews.llvm.org/D79910 Files:

[PATCH] D79910: [x86][seses] Add clang flag; Use lvi-cfi with seses

zbrid added a comment. @sconstab @craig.topper @mattdr -- This is ready for another round of review. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79910/new/ https://reviews.llvm.org/D79910 ___

[PATCH] D79910: [x86][seses] Add clang flag; Use lvi-cfi with seses

zbrid updated this revision to Diff 272114. zbrid added a comment. seses implies lvi-cfi also enable-seses -> enable-seses-without-lvi-cfi Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79910/new/ https://reviews.llvm.org/D79910 Files:

[PATCH] D79910: [x86][seses] Add clang flag; Use lvi-cfi with seses

zbrid added inline comments. Comment at: llvm/lib/Target/X86/X86SpeculativeExecutionSideEffectSuppression.cpp:90 + const X86Subtarget = MF.getSubtarget(); + if (!Subtarget.useSpeculativeExecutionSideEffectSuppression() && +

[PATCH] D79910: [x86][seses] Add clang flag; Use lvi-cfi with seses

zbrid updated this revision to Diff 272105. zbrid marked an inline comment as done. zbrid added a comment. Update Clang Command Ref with automated tool Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79910/new/ https://reviews.llvm.org/D79910

[PATCH] D79910: [x86][seses] Add clang flag; Use lvi-cfi with seses

zbrid marked 2 inline comments as done. zbrid added a comment. Thanks for the ping, Scott. I'll update this so I can get it submitted soon. Comment at: clang/lib/Driver/ToolChains/Arch/X86.cpp:200 +if (!Args.hasArg(options::OPT_mno_lvi_cfi)) { +

[PATCH] D79910: [x86][seses] Add clang flag; Use lvi-cfi with seses

sconstab added a comment. Any progress on this patch? D75939 has been merged, but the SESES feature will not be secure until it has CFI protections. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79910/new/

[PATCH] D79910: [x86][seses] Add clang flag; Use lvi-cfi with seses

sconstab added inline comments. Comment at: clang/lib/Driver/ToolChains/Arch/X86.cpp:200 +if (!Args.hasArg(options::OPT_mno_lvi_cfi)) { + Features.push_back("+lvi-cfi"); + LVIOpt = options::OPT_mlvi_cfi; Would it be better to add

[PATCH] D79910: [x86][seses] Add clang flag; Use lvi-cfi with seses

mattdr added a comment. Took a quick look and seems sane -- will look after Craig's comment is addressed and build is passing Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79910/new/ https://reviews.llvm.org/D79910

[PATCH] D79910: [x86][seses] Add clang flag; Use lvi-cfi with seses

craig.topper added inline comments. Comment at: clang/docs/ClangCommandLineReference.rst:2632 +.. option:: -mseses, -mno-seses + This file is in alphabetical order and is normally generated by a running clang-tblgen. See comment at the top of the file.