[PATCH] D79912: Assignment and Inc/Dec operators wouldn't register as a mutation when Implicit Paren Casts were present

Tridacnid added a comment. I did run both of the testing targets you mentioned, but only on Linux. I'll keep an eye on the buildbot, thanks for the info! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79912/new/ https://reviews.llvm.org/D79912 _

[PATCH] D79912: Assignment and Inc/Dec operators wouldn't register as a mutation when Implicit Paren Casts were present

njames93 added a comment. In D79912#2083477 , @Tridacnid wrote: > Bug report has been closed. I'm seeing some build failures in my inbox but > eyeballing them doesn't make me think this change is related. What is the > expectation for me in this scenario

[PATCH] D79912: Assignment and Inc/Dec operators wouldn't register as a mutation when Implicit Paren Casts were present

Tridacnid added a comment. Bug report has been closed. I'm seeing some build failures in my inbox but eyeballing them doesn't make me think this change is related. What is the expectation for me in this scenario? Will I get an email letting me know once the build has been fixed? Repository:

[PATCH] D79912: Assignment and Inc/Dec operators wouldn't register as a mutation when Implicit Paren Casts were present

This revision was automatically updated to reflect the committed changes. Closed by commit rGce5fecb7d0a1: Assignment and Inc/Dec operators wouldn't register as a mutation when Implicit… (authored by Tridacnid, committed by njames93). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACT

[PATCH] D79912: Assignment and Inc/Dec operators wouldn't register as a mutation when Implicit Paren Casts were present

njames93 added a comment. In D79912#2082337 , @Tridacnid wrote: > tridac...@gmail.com > > https://github.com/Tridacnid > > Thanks! I've commited it on your behalf, w

[PATCH] D79912: Assignment and Inc/Dec operators wouldn't register as a mutation when Implicit Paren Casts were present

Tridacnid added a comment. tridac...@gmail.com https://github.com/Tridacnid Thanks! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79912/new/ https://reviews.llvm.org/D79912 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://l

[PATCH] D79912: Assignment and Inc/Dec operators wouldn't register as a mutation when Implicit Paren Casts were present

njames93 added a comment. In D79912#2081402 , @Tridacnid wrote: > Awesome. I don't have commit access, https://llvm.org/docs/Phabricator.html > says I just need to ask here and someone will pick it up. Let me know if > there's anything else I need to do.

[PATCH] D79912: Assignment and Inc/Dec operators wouldn't register as a mutation when Implicit Paren Casts were present

Tridacnid added a comment. Awesome. I don't have commit access, https://llvm.org/docs/Phabricator.html says I just need to ask here and someone will pick it up. Let me know if there's anything else I need to do. Thanks! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79912/new/ https://

[PATCH] D79912: Assignment and Inc/Dec operators wouldn't register as a mutation when Implicit Paren Casts were present

aaron.ballman accepted this revision. aaron.ballman added a comment. LGTM! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79912/new/ https://reviews.llvm.org/D79912 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.o

[PATCH] D79912: Assignment and Inc/Dec operators wouldn't register as a mutation when Implicit Paren Casts were present

Tridacnid updated this revision to Diff 268991. Tridacnid added a comment. Add (Limit) -= 1 test cases to bugprone-infinite-loop tests CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79912/new/ https://reviews.llvm.org/D79912 Files: clang-tools-extra/test/clang-tidy/checkers/bugprone-i

[PATCH] D79912: Assignment and Inc/Dec operators wouldn't register as a mutation when Implicit Paren Casts were present

njames93 accepted this revision. njames93 added a comment. LGTM, but I wouldn't say no to a test case using `(Limit) -= 1`. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79912/new/ https://reviews.llvm.org/D79912 ___ cfe-commits mailing lis

[PATCH] D79912: Assignment and Inc/Dec operators wouldn't register as a mutation when Implicit Paren Casts were present

gribozavr2 accepted this revision. gribozavr2 added a comment. This revision is now accepted and ready to land. Nice find, thank you for the fix! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79912/new/ https://reviews.llvm.org/D79912 ___ c

[PATCH] D79912: Assignment and Inc/Dec operators wouldn't register as a mutation when Implicit Paren Casts were present

Tridacnid added a comment. Ping CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79912/new/ https://reviews.llvm.org/D79912 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D79912: Assignment and Inc/Dec operators wouldn't register as a mutation when Implicit Paren Casts were present

Tridacnid added a comment. I don't think that did what I wanted. Looks like I should submit the whole change as a single patch? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79912/new/ https://reviews.llvm.org/D79912 ___ cfe-commits mailin

[PATCH] D79912: Assignment and Inc/Dec operators wouldn't register as a mutation when Implicit Paren Casts were present

Tridacnid updated this revision to Diff 263887. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79912/new/ https://reviews.llvm.org/D79912 Files: clang-tools-extra/test/clang-tidy/checkers/bugprone-infinite-loop.cpp clang/lib/Analysis/ExprMutationAnalyzer.cpp clang/unittests/Analysis

[PATCH] D79912: Assignment and Inc/Dec operators wouldn't register as a mutation when Implicit Paren Casts were present

Tridacnid updated this revision to Diff 263885. Tridacnid added a comment. Apply clang-format patch. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79912/new/ https://reviews.llvm.org/D79912 Files: clang/unittests/Analysis/ExprMutationAnalyzerTest.cpp Index: clang/unittests/Analysis

[PATCH] D79912: Assignment and Inc/Dec operators wouldn't register as a mutation when Implicit Paren Casts were present

Tridacnid created this revision. Tridacnid added reviewers: llvm-commits, alexfh, klimek. Tridacnid added projects: clang-tools-extra, clang. Herald added a subscriber: cfe-commits. Add ignoringParenImpCasts to assignment and inc/dec mutation checks in ExprMutationAnalyzer to fix clang-tidy bug P