This revision was automatically updated to reflect the committed changes.
Closed by commit rGe8ea35e63f50: [clang-format] [PR44345] Long namespace
closing comment is duplicated endlessly (authored by MyDeveloperDay).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://revie
MyDeveloperDay updated this revision to Diff 264319.
MyDeveloperDay added a comment.
Fix typo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D79935/new/
https://reviews.llvm.org/D79935
Files:
clang/lib/Format/NamespaceEndCommentsFixer.cpp
clang/unittests/Format/FormatTest.cpp
Index:
curdeius added inline comments.
Comment at: clang/lib/Format/NamespaceEndCommentsFixer.cpp:129
+ // } // namespace
+ // // verylongnamespacenamethatdidnotfitonthepreviouscommenline
+ if (!(Comment->Next && Comment->Next->is(TT_LineComment)))
Nit: typo commen
krasimir accepted this revision.
krasimir added a comment.
This revision is now accepted and ready to land.
Awesome! Thank you!
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D79935/new/
https://reviews.llvm.org/D79935
MyDeveloperDay created this revision.
MyDeveloperDay added reviewers: krasimir, JakeMerdichAMD, mitchell-stellar,
sammccall, curdeius.
MyDeveloperDay added projects: clang, clang-format.
https://bugs.llvm.org/show_bug.cgi?id=44345
When namespaces get long the namespace end comment wraps onto the
