[PATCH] D79961: [PGO] Fix computation of fuction Hash

serge-sans-paille added a comment. In D79961#2065605 , @alanphipps wrote: > It looks like clang/test/Profile/Inputs/c-general.profdata.v5 is being read > as v6 rather than v5. Can you double check? Thanks for spotting the issue. Should be fixed by 634

[PATCH] D79961: [PGO] Fix computation of fuction Hash

serge-sans-paille added a comment. In D79961#2065605 , @alanphipps wrote: > It looks like clang/test/Profile/Inputs/c-general.profdata.v5 is being read > as v6 rather than v5. Can you double check? Yep, I'll have a look. Repository: rG LLVM Github

[PATCH] D79961: [PGO] Fix computation of fuction Hash

alanphipps added a comment. It looks like clang/test/Profile/Inputs/c-general.profdata.v5 is being read as v6 rather than v5. Can you double check? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79961/new/ https://reviews.llvm.org/D79961 __

[PATCH] D79961: [PGO] Fix computation of fuction Hash

This revision was automatically updated to reflect the committed changes. Closed by commit rGde02a75e3984: [PGO] Fix computation of function Hash (authored by serge-sans-paille). Changed prior to commit: https://reviews.llvm.org/D79961?vs=266188&id=266441#toc Repository: rG LLVM Github Monor

[PATCH] D79961: [PGO] Fix computation of fuction Hash

hans accepted this revision. hans added a comment. lgtm CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79961/new/ https://reviews.llvm.org/D79961 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/

[PATCH] D79961: [PGO] Fix computation of fuction Hash

serge-sans-paille updated this revision to Diff 266188. serge-sans-paille marked an inline comment as done. serge-sans-paille added a comment. Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Update version bump parts CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79

[PATCH] D79961: [PGO] Fix computation of fuction Hash

serge-sans-paille updated this revision to Diff 266184. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79961/new/ https://reviews.llvm.org/D79961 Files: clang/docs/ReleaseNotes.rst clang/lib/CodeGen/CodeGenPGO.cpp clang/test/Profile/Inputs/c-counter-overflows.proftext clang/test/P

[PATCH] D79961: [PGO] Fix computation of fuction Hash

hans added a comment. I worry that the hash version bump isn't complete. Doesn't the hash version used need to be read/written with the profile data file somewhere? Comment at: clang/lib/CodeGen/CodeGenPGO.cpp:148 return PGO_HASH_V1; return PGO_HASH_V2; }

[PATCH] D79961: [PGO] Fix computation of fuction Hash

serge-sans-paille added a comment. @hans updated! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79961/new/ https://reviews.llvm.org/D79961 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listin

[PATCH] D79961: [PGO] Fix computation of fuction Hash

serge-sans-paille updated this revision to Diff 266133. serge-sans-paille added a comment. With v3 version + Make cast explicit CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79961/new/ https://reviews.llvm.org/D79961 Files: clang/docs/ReleaseNotes.rst clang/lib/CodeGen/CodeGenPGO.c

[PATCH] D79961: [PGO] Fix computation of fuction Hash

hans added a comment. In D79961#2053806 , @serge-sans-paille wrote: > Bump the version number to be compatible with existing profdata, in a similar > fashion to v1/v2 transition. Did you forget to include some files? I don't see the bump anywhere. =

[PATCH] D79961: [PGO] Fix computation of fuction Hash

serge-sans-paille updated this revision to Diff 266072. serge-sans-paille added a comment. Bump the version number to be compatible with existing profdata, in a similar fashion to v1/v2 transition. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D7996

[PATCH] D79961: [PGO] Fix computation of fuction Hash

serge-sans-paille added a comment. @hans/ @MaskRay I'm starting to wonder if I should bump the version number of the hash function, so that clang could still read profile data generated before that patch? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79961/new/ https://reviews.llvm.or

[PATCH] D79961: [PGO] Fix computation of fuction Hash

MaskRay accepted this revision. MaskRay added a comment. Thanks! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79961/new/ https://reviews.llvm.org/D79961 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin

[PATCH] D79961: [PGO] Fix computation of fuction Hash

serge-sans-paille updated this revision to Diff 266064. serge-sans-paille added a comment. Update profile data hash entries due to hash function update, unless the version used is V1, in which case we keep the buggy behavior for backward compatibility. CHANGES SINCE LAST ACTION https://r

[PATCH] D79961: [PGO] Fix computation of fuction Hash

serge-sans-paille reopened this revision. serge-sans-paille added a subscriber: bkramer. serge-sans-paille added a comment. This revision is now accepted and ready to land. @bkramer rightfully reverted this, faster than I could patch it :-) Here is the patch though, with the updated test case. @h

[PATCH] D79961: [PGO] Fix computation of fuction Hash

ormris added a comment. There's a few test failures related to this change on the PS4 bot. Could you take a look? http://lab.llvm.org:8011/builders/llvm-clang-lld-x86_64-scei-ps4-ubuntu-fast/builds/68111 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.or

[PATCH] D79961: [PGO] Fix computation of fuction Hash

This revision was automatically updated to reflect the committed changes. Closed by commit rG7c298c104bfe: [PGO] Fix computation of function Hash (authored by serge-sans-paille). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79961/new/ https://revie

[PATCH] D79961: [PGO] Fix computation of fuction Hash

hans accepted this revision. hans added a comment. This revision is now accepted and ready to land. lgtm Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79961/new/ https://reviews.llvm.org/D79961 ___ cfe

[PATCH] D79961: [PGO] Fix computation of fuction Hash

serge-sans-paille added a comment. Up? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79961/new/ https://reviews.llvm.org/D79961 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llv

[PATCH] D79961: [PGO] Fix computation of fuction Hash

serge-sans-paille added a comment. > May I ask how you found this? This was a long (and painful) quest when tracking https://bugzilla.redhat.com/show_bug.cgi?id=1827282 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79961/new/ https://reviews.ll

[PATCH] D79961: [PGO] Fix computation of fuction Hash

hans added a comment. Nice fix, and nice test :-) May I ask how you found this? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79961/new/ https://reviews.llvm.org/D79961 ___ cfe-commits mailing list cf

[PATCH] D79961: [PGO] Fix computation of fuction Hash

serge-sans-paille updated this revision to Diff 264552. serge-sans-paille edited the summary of this revision. serge-sans-paille added a comment. Updated summary + removed namespace. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79961/new/ https://

[PATCH] D79961: [PGO] Fix computation of fuction Hash

MaskRay added inline comments. Comment at: clang/lib/CodeGen/CodeGenPGO.cpp:759 MD5.final(Result); using namespace llvm::support; return Result.low(); Can the using be deleted? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://

[PATCH] D79961: [PGO] Fix computation of fuction Hash

MaskRay added a comment. This patch is correct. A clarification of the description: > Previous implementation was incorrectly passing an integer, that got > converted to a pointer, to finalize the hash computation. Working (an `uint64_t`) was truncated to an `uint8_t`, converted to a one-eleme

[PATCH] D79961: [PGO] Fix computation of fuction Hash

serge-sans-paille updated this revision to Diff 264084. serge-sans-paille added a comment. Update test case Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79961/new/ https://reviews.llvm.org/D79961 Files: clang/lib/CodeGen/CodeGenPGO.cpp clang/

[PATCH] D79961: [PGO] Fix computation of fuction Hash

serge-sans-paille created this revision. serge-sans-paille added reviewers: dexonsmith, zturner. serge-sans-paille added a project: clang. Herald added a subscriber: cfe-commits. Previous implementation was incorrectly passing an integer, that got converted to a pointer, to finalize the hash compu