kadircet marked 3 inline comments as done.
kadircet added inline comments.
Comment at: clang-tools-extra/clangd/Preamble.cpp:419
+ if (DirectivesChanged) {
+// We need to patch all the directives, since they are order dependent.
e.g:
+// #define BAR(X) NEW(X) // Newly i
sammccall added inline comments.
Comment at: clang-tools-extra/clangd/Preamble.cpp:419
+ if (DirectivesChanged) {
+// We need to patch all the directives, since they are order dependent.
e.g:
+// #define BAR(X) NEW(X) // Newly introduced in Modified
Hmm
kadircet updated this revision to Diff 264666.
kadircet added a comment.
- MacroInfo's definition range is a token range, convert it to a char range.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D79992/new/
https://reviews.llvm.org/D79992
Files:
kadircet updated this revision to Diff 264567.
kadircet added a comment.
- Only store defines
- Make use of source text directly instead of printing tokens
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D79992/new/
https://reviews.llvm.org/D79992
Fi
kadircet created this revision.
kadircet added a reviewer: sammccall.
Herald added subscribers: cfe-commits, usaxena95, arphaman, jkorous, MaskRay,
ilya-biryukov.
Herald added a project: clang.
kadircet retitled this revision from "[clangd] Patch PP directives to use stale
preambles while buildin
