This revision was automatically updated to reflect the committed changes.
nemanjai marked an inline comment as done.
Closed by commit rG9021ce9576e4: [Clang] Enable KF and KC mode for [_Complex]
__float128 (authored by nemanjai).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
rjmccall accepted this revision.
rjmccall added a comment.
This revision is now accepted and ready to land.
Thanks
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D80374/new/
https://reviews.llvm.org/D80374
_
nemanjai marked 3 inline comments as done.
nemanjai added inline comments.
Comment at: clang/lib/Sema/SemaDeclAttr.cpp:3970
+ DestWidth = 128;
+ break;
case 'T':
rjmccall wrote:
> rjmccall wrote:
> > Are there interactions with the other mode speci
nemanjai updated this revision to Diff 266820.
nemanjai added a comment.
Handled invalid uses of `KI` as there is no corresponding integer mode and
added testing for it.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D80374/new/
https://reviews.llvm
rjmccall added inline comments.
Comment at: clang/lib/Sema/SemaDeclAttr.cpp:3970
+ DestWidth = 128;
+ break;
case 'T':
Are there interactions with the other mode specifiers? For example, should
this be allowed with integer modes? If so, I think
rjmccall added inline comments.
Comment at: clang/lib/Sema/SemaDeclAttr.cpp:3970
+ DestWidth = 128;
+ break;
case 'T':
rjmccall wrote:
> Are there interactions with the other mode specifiers? For example, should
> this be allowed with integer mod
nemanjai updated this revision to Diff 266092.
nemanjai added a comment.
Remove handling for explicit `_Complex __float128`.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D80374/new/
https://reviews.llvm.org/D80374
Files:
clang/include/clang/AST/
nemanjai added a comment.
The support for `_Complex __float128` in https://reviews.llvm.org/D80533
I will repurpose leave only the addition of the `KF/KC` modes in this patch.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D80374/new/
https://reviews
rjmccall added a comment.
Would you mind separating these two patches? They don't seem have any
interdependencies.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D80374/new/
https://reviews.llvm.org/D80374
___
nemanjai created this revision.
nemanjai added reviewers: rjmccall, rsmith, PowerPC, hfinkel.
Herald added subscribers: dexonsmith, kbarton.
Herald added a reviewer: aaron.ballman.
Herald added a project: clang.
The headers provided with recent GNU toolchains for PPC have code that includes
typed
10 matches
Mail list logo