[PATCH] D80425: Fix LLVM/Clang builds with mingw toolchain

thieta added a comment. Sounds good - I'll close this one and open three new ones. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80425/new/ https://reviews.llvm.org/D80425 ___ cfe-commits mailing list

[PATCH] D80425: Fix LLVM/Clang builds with mingw toolchain

mstorsjo added a comment. In D80425#2052607 , @thieta wrote: > I am planning to revise this one now that we have thinlto-cache-dir option > landed here are my plans: > > - Keep the libdl patch as is (seems like there are no more comments on this). > -

[PATCH] D80425: Fix LLVM/Clang builds with mingw toolchain

thieta added a comment. I am planning to revise this one now that we have thinlto-cache-dir option landed here are my plans: - Keep the libdl patch as is (seems like there are no more comments on this). - Remove the symlink patch for now and potentially move that to another patch - Rework the

[PATCH] D80425: Fix LLVM/Clang builds with mingw toolchain

thieta added a comment. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80425/new/ https://reviews.llvm.org/D80425 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D80425: Fix LLVM/Clang builds with mingw toolchain

mati865 added inline comments. Comment at: llvm/cmake/modules/HandleLLVMOptions.cmake:967 CMAKE_EXE_LINKER_FLAGS CMAKE_SHARED_LINKER_FLAGS) - elseif(LINKER_IS_LLD_LINK) + elseif(LINKER_IS_LLD_LINK AND NOT MINGW)

[PATCH] D80425: Fix LLVM/Clang builds with mingw toolchain

mstorsjo added inline comments. Comment at: llvm/cmake/modules/HandleLLVMOptions.cmake:967 CMAKE_EXE_LINKER_FLAGS CMAKE_SHARED_LINKER_FLAGS) - elseif(LINKER_IS_LLD_LINK) + elseif(LINKER_IS_LLD_LINK AND NOT MINGW)

[PATCH] D80425: Fix LLVM/Clang builds with mingw toolchain

thieta added a comment. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80425/new/ https://reviews.llvm.org/D80425 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D80425: Fix LLVM/Clang builds with mingw toolchain

mati865 added inline comments. Comment at: llvm/cmake/modules/HandleLLVMOptions.cmake:967 CMAKE_EXE_LINKER_FLAGS CMAKE_SHARED_LINKER_FLAGS) - elseif(LINKER_IS_LLD_LINK) + elseif(LINKER_IS_LLD_LINK AND NOT MINGW)

[PATCH] D80425: Fix LLVM/Clang builds with mingw toolchain

mstorsjo added inline comments. Comment at: clang/tools/libclang/CMakeLists.txt:71 + list(APPEND LIBS ${CMAKE_DL_LIBS}) endif() mati865 wrote: > thieta wrote: > > mstorsjo wrote: > > > If you say this is the same way it's done elsewhere, then sure - although

[PATCH] D80425: Fix LLVM/Clang builds with mingw toolchain

mati865 added inline comments. Comment at: clang/tools/libclang/CMakeLists.txt:71 + list(APPEND LIBS ${CMAKE_DL_LIBS}) endif() thieta wrote: > mstorsjo wrote: > > If you say this is the same way it's done elsewhere, then sure - although I > > have no idea

[PATCH] D80425: Fix LLVM/Clang builds with mingw toolchain

thieta marked 5 inline comments as done. thieta added inline comments. Comment at: clang/tools/libclang/CMakeLists.txt:71 + list(APPEND LIBS ${CMAKE_DL_LIBS}) endif() mstorsjo wrote: > If you say this is the same way it's done elsewhere, then sure - although

[PATCH] D80425: Fix LLVM/Clang builds with mingw toolchain

mstorsjo added a comment. Super-nitpick: If you want to capitalize mingw, it's MinGW (minimalist gnu for windows)  But as that's rather annoying to type, the all-lowercase version is quite fine as well. Comment at: clang/tools/libclang/CMakeLists.txt:71 + list(APPEND LIBS

[PATCH] D80425: Fix LLVM/Clang builds with mingw toolchain

thieta created this revision. Herald added subscribers: llvm-commits, cfe-commits, mstorsjo, dexonsmith, mgorny. Herald added projects: clang, LLVM. These are a collection of small fixes to make LLVM/Clang build with a clang+mingw toolchain to target Windows. The three commits address the