[PATCH] D80716: [AArch64]: BFloat Load/Store Intrinsics

stuij accepted this revision. stuij added a comment. This revision is now accepted and ready to land. LGTM. Thanks! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80716/new/ https://reviews.llvm.org/D80716 ___ cfe-commits mailing list

[PATCH] D80716: [AArch64]: BFloat Load/Store Intrinsics

LukeGeeson updated this revision to Diff 270387. LukeGeeson added a comment. - removed unnecessary contents of test CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80716/new/ https://reviews.llvm.org/D80716 Files: clang/include/clang/Basic/arm_neon.td clang/lib/CodeGen/CGBuiltin.cpp

[PATCH] D80716: [AArch64]: BFloat Load/Store Intrinsics

stuij added inline comments. Comment at: llvm/test/CodeGen/AArch64/aarch64-bf16-ldst-intrinsics.ll:264 +; Function Attrs: argmemonly nounwind readonly +declare { <8 x bfloat>, <8 x bfloat> } @llvm.aarch64.neon.ld2lane.v8bf16.p0i8(<8 x bfloat>, <8 x bfloat>, i64, i8*) #3 +

[PATCH] D80716: [AArch64]: BFloat Load/Store Intrinsics

chill added inline comments. Comment at: llvm/test/CodeGen/AArch64/aarch64-bf16-ldst-intrinsics.ll:264 +; Function Attrs: argmemonly nounwind readonly +declare { <8 x bfloat>, <8 x bfloat> } @llvm.aarch64.neon.ld2lane.v8bf16.p0i8(<8 x bfloat>, <8 x bfloat>, i64, i8*) #3 +

[PATCH] D80716: [AArch64]: BFloat Load/Store Intrinsics

SjoerdMeijer added inline comments. Comment at: llvm/test/CodeGen/AArch64/aarch64-bf16-ldst-intrinsics.ll:264 +; Function Attrs: argmemonly nounwind readonly +declare { <8 x bfloat>, <8 x bfloat> } @llvm.aarch64.neon.ld2lane.v8bf16.p0i8(<8 x bfloat>, <8 x bfloat>, i64, i8*) #3

[PATCH] D80716: [AArch64]: BFloat Load/Store Intrinsics

chill added inline comments. Comment at: llvm/test/CodeGen/AArch64/aarch64-bf16-ldst-intrinsics.ll:264 +; Function Attrs: argmemonly nounwind readonly +declare { <8 x bfloat>, <8 x bfloat> } @llvm.aarch64.neon.ld2lane.v8bf16.p0i8(<8 x bfloat>, <8 x bfloat>, i64, i8*) #3 +

[PATCH] D80716: [AArch64]: BFloat Load/Store Intrinsics

SjoerdMeijer added inline comments. Comment at: llvm/test/CodeGen/AArch64/aarch64-bf16-ldst-intrinsics.ll:264 +; Function Attrs: argmemonly nounwind readonly +declare { <8 x bfloat>, <8 x bfloat> } @llvm.aarch64.neon.ld2lane.v8bf16.p0i8(<8 x bfloat>, <8 x bfloat>, i64, i8*) #3

[PATCH] D80716: [AArch64]: BFloat Load/Store Intrinsics

chill added inline comments. Comment at: llvm/test/CodeGen/AArch64/aarch64-bf16-ldst-intrinsics.ll:264 +; Function Attrs: argmemonly nounwind readonly +declare { <8 x bfloat>, <8 x bfloat> } @llvm.aarch64.neon.ld2lane.v8bf16.p0i8(<8 x bfloat>, <8 x bfloat>, i64, i8*) #3 +

[PATCH] D80716: [AArch64]: BFloat Load/Store Intrinsics

LukeGeeson marked 2 inline comments as done. LukeGeeson added inline comments. Comment at: llvm/test/CodeGen/AArch64/aarch64-bf16-ldst-intrinsics.ll:264 +; Function Attrs: argmemonly nounwind readonly +declare { <8 x bfloat>, <8 x bfloat> }

[PATCH] D80716: [AArch64]: BFloat Load/Store Intrinsics

SjoerdMeijer added inline comments. Comment at: llvm/test/CodeGen/AArch64/aarch64-bf16-ldst-intrinsics.ll:264 +; Function Attrs: argmemonly nounwind readonly +declare { <8 x bfloat>, <8 x bfloat> } @llvm.aarch64.neon.ld2lane.v8bf16.p0i8(<8 x bfloat>, <8 x bfloat>, i64, i8*) #3

[PATCH] D80716: [AArch64]: BFloat Load/Store Intrinsics

LukeGeeson marked 2 inline comments as done. LukeGeeson added inline comments. Comment at: llvm/test/CodeGen/AArch64/aarch64-bf16-ldst-intrinsics.ll:264 +; Function Attrs: argmemonly nounwind readonly +declare { <8 x bfloat>, <8 x bfloat> }

[PATCH] D80716: [AArch64]: BFloat Load/Store Intrinsics

arsenm added inline comments. Comment at: llvm/test/CodeGen/AArch64/aarch64-bf16-ldst-intrinsics.ll:264 +; Function Attrs: argmemonly nounwind readonly +declare { <8 x bfloat>, <8 x bfloat> } @llvm.aarch64.neon.ld2lane.v8bf16.p0i8(<8 x bfloat>, <8 x bfloat>, i64, i8*) #3 +

[PATCH] D80716: [AArch64]: BFloat Load/Store Intrinsics

LukeGeeson added a comment. In D80716#2082356 , @LukeGeeson wrote: > In D80716#2074883 , @stuij wrote: > > > In D80716#2073251 , @LukeGeeson > > wrote: > > > > > Besides

[PATCH] D80716: [AArch64]: BFloat Load/Store Intrinsics

LukeGeeson added a comment. In D80716#2074883 , @stuij wrote: > In D80716#2073251 , @LukeGeeson > wrote: > > > Besides from rebasing to get @pratlucas changes upstream. > > > > @stuij please could you confirm if

[PATCH] D80716: [AArch64]: BFloat Load/Store Intrinsics

stuij added a comment. In D80716#2073251 , @LukeGeeson wrote: > Besides from rebasing to get @pratlucas changes upstream. > > @stuij please could you confirm if you are happy with this, so I can merge Hi Luke, For the backend tests it would be good if

[PATCH] D80716: [AArch64]: BFloat Load/Store Intrinsics

LukeGeeson added a comment. Besides from rebasing to get @pratlucas changes upstream. @stuij please could you confirm if you are happy with this, so I can merge CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80716/new/ https://reviews.llvm.org/D80716

[PATCH] D80716: [AArch64]: BFloat Load/Store Intrinsics

LukeGeeson marked an inline comment as done. LukeGeeson added inline comments. Comment at: clang/lib/CodeGen/CGBuiltin.cpp:10366 +auto Alignment = CGM.getNaturalPointeeTypeAlignment( +E->getArg(0)->IgnoreParenCasts()->getType()); Ops[0] =

[PATCH] D80716: [AArch64]: BFloat Load/Store Intrinsics

pratlucas added inline comments. Comment at: clang/lib/CodeGen/CGBuiltin.cpp:10366 +auto Alignment = CGM.getNaturalPointeeTypeAlignment( +E->getArg(0)->IgnoreParenCasts()->getType()); Ops[0] = Builder.CreateBitCast(Ops[0], llvm::PointerType::getUnqual(VTy));

[PATCH] D80716: [AArch64]: BFloat Load/Store Intrinsics

LukeGeeson added a comment. In D80716#2059977 , @stuij wrote: > We need testing for the backend code. @stuij I have added `aarch64-bf16-ldst-intrinsics.ll` to test the backend. Please let me know if this is ok :) CHANGES SINCE LAST ACTION

[PATCH] D80716: [AArch64]: BFloat Load/Store Intrinsics

LukeGeeson updated this revision to Diff 267896. LukeGeeson marked 4 inline comments as done. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80716/new/ https://reviews.llvm.org/D80716 Files: clang/include/clang/Basic/arm_neon.td clang/lib/CodeGen/CGBuiltin.cpp

[PATCH] D80716: [AArch64]: BFloat Load/Store Intrinsics

LukeGeeson added a subscriber: pratlucas. LukeGeeson added inline comments. Comment at: clang/lib/CodeGen/CGBuiltin.cpp:10366 +auto Alignment = CGM.getNaturalPointeeTypeAlignment( +E->getArg(0)->IgnoreParenCasts()->getType()); Ops[0] =

[PATCH] D80716: [AArch64]: BFloat Load/Store Intrinsics

simon_tatham added inline comments. Comment at: clang/lib/CodeGen/CGBuiltin.cpp:10366 +auto Alignment = CGM.getNaturalPointeeTypeAlignment( +E->getArg(0)->IgnoreParenCasts()->getType()); Ops[0] = Builder.CreateBitCast(Ops[0], llvm::PointerType::getUnqual(VTy));

[PATCH] D80716: [AArch64]: BFloat Load/Store Intrinsics

stuij requested changes to this revision. stuij added a comment. This revision now requires changes to proceed. We need testing for the backend code. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80716/new/ https://reviews.llvm.org/D80716

[PATCH] D80716: [AArch64]: BFloat Load/Store Intrinsics

labrinea added inline comments. Comment at: clang/test/CodeGen/aarch64-bf16-ldst-intrinsics.c:36 +// CHECK32: ret <4 x bfloat> %vld1_lane + +bfloat16x8_t test_vld1q_lane_bf16(bfloat16_t const *ptr, bfloat16x8_t src) { CHECK-NEXT or CHECK-DAG are preferable for

[PATCH] D80716: [AArch64]: BFloat Load/Store Intrinsics

LukeGeeson created this revision. LukeGeeson added reviewers: fpetrogalli, SjoerdMeijer. Herald added subscribers: llvm-commits, cfe-commits, danielkiss, hiraditya, kristof.beyls. Herald added projects: clang, LLVM. LukeGeeson added a parent revision: D79869: [clang][BFloat] Add reinterpret cast