steven.zhang added a comment.
It LGTM now except one comment on the test. And it seems that, we still have
many other builtins implementation that didn't use the _Generic.
Comment at: clang/test/CodeGen/ppc-emmintrin.c:1
-// NOTE: Assertions have been autogenerated by
vddvss updated this revision to Diff 267529.
vddvss marked an inline comment as done.
vddvss added a comment.
Updated revision to address @steven.zhang's good suggestion on the test case.
This also does `clang-format` on `altivec.h` to address the harbormaster
failure, although I am inclined to
steven.zhang added inline comments.
Comment at: clang/lib/Headers/altivec.h:13670
+ )
+#elif defined(__VSX__)
+#define vec_splats(N) \
vddvss wrote:
> steven.zhang wrote:
> > I am not sure if this is by intention. It is not
vddvss added inline comments.
Comment at: clang/lib/Headers/altivec.h:13670
+ )
+#elif defined(__VSX__)
+#define vec_splats(N) \
steven.zhang wrote:
> I am not sure if this is by intention. It is not semantics the same with
steven.zhang added inline comments.
Comment at: clang/lib/Headers/altivec.h:13670
+ )
+#elif defined(__VSX__)
+#define vec_splats(N) \
I am not sure if this is by intention. It is not semantics the same with this
change.
vddvss created this revision.
vddvss added reviewers: nemanjai, PowerPC.
Herald added subscribers: cfe-commits, shchenz, kbarton.
Herald added a project: clang.
This commit converts the `vec_splats` functions in altivec.h to macros, solving
an issue where `vec_splats` calls could not assign to
