This revision was automatically updated to reflect the committed changes.
Closed by commit rGef1d4bec891b: [Clang][CGM] style cleanups NFC (authored by
nickdesaulniers).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D80840/new/
https://reviews.llvm.o
nickdesaulniers added a comment.
I've learned the hard way not to commit code Friday >4pm. Will land Monday.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D80840/new/
https://reviews.llvm.org/D80840
__
nickdesaulniers updated this revision to Diff 267403.
nickdesaulniers added a comment.
- actually, braces were unnecessary
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D80840/new/
https://reviews.llvm.org/D80840
Files:
clang/lib/CodeGen/CodeGenM
nickdesaulniers updated this revision to Diff 267399.
nickdesaulniers added a comment.
- add missed `{`, actually compile test and check all
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D80840/new/
https://reviews.llvm.org/D80840
Files:
clang/li
nickdesaulniers marked an inline comment as done.
nickdesaulniers added inline comments.
Comment at: clang/lib/CodeGen/CodeGenModule.cpp:5374
case Decl::CXXRecord:
-if (DebugInfo) {
+if (CGDebugInfo *DI = getModuleDebugInfo())
if (auto *ES = D->getASTContext().g
dblaikie accepted this revision.
dblaikie added a comment.
This revision is now accepted and ready to land.
Sounds good - thanks!
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D80840/new/
https://reviews.llvm.org/D80840
__
nickdesaulniers created this revision.
nickdesaulniers added a reviewer: dblaikie.
Herald added a project: clang.
Herald added a subscriber: cfe-commits.
Forked from:
https://reviews.llvm.org/D80242
Use the getter for access to DebugInfo consistently.
Use break in switch in CodeGenModule::EmitTop
