[PATCH] D81282: [builtins] Move more float128-related helpers to GENERIC_TF_SOURCES list

2020-06-25 Thread Anton Korobeynikov via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rGa931ec7ca0ee: [builtins] Move more float128-related helpers to GENERIC_TF_SOURCES list (authored by atrosinenko, committed by asl). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https

[PATCH] D81282: [builtins] Move more float128-related helpers to GENERIC_TF_SOURCES list

2020-06-25 Thread Eli Friedman via Phabricator via cfe-commits
efriedma accepted this revision. efriedma added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81282/new/ https://reviews.llvm.org/D81282 ___

[PATCH] D81282: [builtins] Move more float128-related helpers to GENERIC_TF_SOURCES list

2020-06-25 Thread Anatoly Trosinenko via Phabricator via cfe-commits
atrosinenko marked an inline comment as done. atrosinenko added inline comments. Comment at: compiler-rt/lib/builtins/CMakeLists.txt:142 powisf2.c powitf2.c subdf3.c efriedma wrote: > Missed powitf? Fixed, thank you. Repository: rG LLVM Github Monore

[PATCH] D81282: [builtins] Move more float128-related helpers to GENERIC_TF_SOURCES list

2020-06-25 Thread Anatoly Trosinenko via Phabricator via cfe-commits
atrosinenko updated this revision to Diff 273452. atrosinenko added a comment. Move missed `powitf2.c` source as well. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81282/new/ https://reviews.llvm.org/D81282 Files: compiler-rt/lib/builtins/CMake

[PATCH] D81282: [builtins] Move more float128-related helpers to GENERIC_TF_SOURCES list

2020-06-25 Thread Eli Friedman via Phabricator via cfe-commits
efriedma added inline comments. Comment at: compiler-rt/lib/builtins/CMakeLists.txt:142 powisf2.c powitf2.c subdf3.c Missed powitf? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81282/new/ https://reviews

[PATCH] D81282: [builtins] Move more float128-related helpers to GENERIC_TF_SOURCES list

2020-06-25 Thread Ayke via Phabricator via cfe-commits
aykevl added a comment. Look reasonable from my POV, but I don't know enough about CMake or the compiler-rt build system to LGTM this. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81282/new/ https://reviews.llvm.org/D81282

[PATCH] D81282: [builtins] Move more float128-related helpers to GENERIC_TF_SOURCES list

2020-06-25 Thread Anatoly Trosinenko via Phabricator via cfe-commits
atrosinenko added a comment. Ping. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81282/new/ https://reviews.llvm.org/D81282 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.or

[PATCH] D81282: [builtins] Move more float128-related helpers to GENERIC_TF_SOURCES list

2020-06-18 Thread Anatoly Trosinenko via Phabricator via cfe-commits
atrosinenko added a comment. @samsonov Something strange happens with the compiler-rt tests: when this patch was initially uploaded, the tests were failed with seemingly unrelated failures: B59287 . Some tests are broken upstream, I concluded. Today I have reba

[PATCH] D81282: [builtins] Move more float128-related helpers to GENERIC_TF_SOURCES list

2020-06-18 Thread Anatoly Trosinenko via Phabricator via cfe-commits
atrosinenko updated this revision to Diff 271612. atrosinenko added a comment. 1. Since different quite unrelated patches failed on Jun 5 with quite the same messages, just rebase onto current `master` expecting build failure to go away 2. Ping Repository: rG LLVM Github Monorepo CHANGES SIN

[PATCH] D81282: [builtins] Move more float128-related helpers to GENERIC_TF_SOURCES list

2020-06-05 Thread Anatoly Trosinenko via Phabricator via cfe-commits
atrosinenko created this revision. atrosinenko added reviewers: howard.hinnant, samsonov. Herald added subscribers: Sanitizers, mgorny. Herald added a project: Sanitizers. There are two different _generic_ lists of source files in the compiler-rt/lib/builtins/CMakeLists.txt. Now there is no simpl