[PATCH] D81428: [ARM] Moving CMSE handling of half arguments and return to the backend

This revision was automatically updated to reflect the committed changes. Closed by commit rG92ad6d57c218: [ARM] Moving CMSE handling of half arguments and return to the backend (authored by pratlucas). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D81428: [ARM] Moving CMSE handling of half arguments and return to the backend

ostannard accepted this revision. ostannard added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81428/new/ https://reviews.llvm.org/D81428

[PATCH] D81428: [ARM] Moving CMSE handling of half arguments and return to the backend

pratlucas marked 4 inline comments as done. pratlucas added inline comments. Comment at: llvm/lib/Target/ARM/ARMISelLowering.cpp:2267 +// Mask f16 arguments if this is a CMSE nonsecure call +auto ArgVT = Outs[realArgIdx].ArgVT; ostannard wrote: > Could

[PATCH] D81428: [ARM] Moving CMSE handling of half arguments and return to the backend

pratlucas updated this revision to Diff 270160. pratlucas added a comment. Addressing review comment. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81428/new/ https://reviews.llvm.org/D81428 Files: llvm/lib/Target/ARM/ARMISelLowering.cpp

[PATCH] D81428: [ARM] Moving CMSE handling of half arguments and return to the backend

pratlucas updated this revision to Diff 270149. pratlucas added a comment. Rebasing and simplifying function attributes on test. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81428/new/ https://reviews.llvm.org/D81428 Files:

[PATCH] D81428: [ARM] Moving CMSE handling of half arguments and return to the backend

ostannard added a comment. Is this expected to work for the soft-float calling convention, or is clang still passing half-precision values as integer types for that? If the former, then this needs some tests for that case. Comment at:

[PATCH] D81428: [ARM] Moving CMSE handling of half arguments and return to the backend

pratlucas updated this revision to Diff 269452. pratlucas added a comment. Moving the clean-up of the Clang-side handling to a separate patch. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81428/new/ https://reviews.llvm.org/D81428 Files:

[PATCH] D81428: [ARM] Moving CMSE handling of half arguments and return to the backend

pratlucas created this revision. Herald added subscribers: llvm-commits, cfe-commits, danielkiss, hiraditya, kristof.beyls. Herald added projects: clang, LLVM. pratlucas added reviewers: chill, rjmccall, ostannard. pratlucas added a parent revision: D75169: [ARM] Enforcing calling convention for