[PATCH] D81432: Add #includes so that ROCm.h is compilable stand-alone.

2020-06-08 Thread James Y Knight via Phabricator via cfe-commits
jyknight added a comment. LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81432/new/ https://reviews.llvm.org/D81432 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D81432: Add #includes so that ROCm.h is compilable stand-alone.

2020-06-08 Thread Sterling Augustine via Phabricator via cfe-commits
This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rGf07b3d41e739: Add #includes so that ROCm.h is compilable stand-alone. (authored by saugustine). Repository: rG LLVM

[PATCH] D81432: Add #includes so that ROCm.h is compilable stand-alone.

2020-06-08 Thread Sterling Augustine via Phabricator via cfe-commits
saugustine added a comment. For post-commit review. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81432/new/ https://reviews.llvm.org/D81432 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D81432: Add #includes so that ROCm.h is compilable stand-alone.

2020-06-08 Thread Sterling Augustine via Phabricator via cfe-commits
saugustine created this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. saugustine added reviewers: jyknight, echristo. saugustine added a comment. For post-commit review. ROCm.h had been getting the declarations for various data structures by being #included