[PATCH] D81720: [clangd] Change prepareCompilerInstance to take an FSProvider

2020-06-17 Thread Sam McCall via Phabricator via cfe-commits
sammccall added a comment. Yay for getting rid of more VFSes passed around. Not sure about some of the other signature changes to prepareCompilerInstance. It seems a bit harder to call now. In particular I'm not sure whether moving the preamble-stat-cache across setup from caller to callee is

[PATCH] D81720: [clangd] Change prepareCompilerInstance to take an FSProvider

2020-06-12 Thread Kadir Cetinkaya via Phabricator via cfe-commits
kadircet updated this revision to Diff 270333. kadircet added a comment. - Use Cmd.Directory when creating includefixer. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81720/new/ https://reviews.llvm.org/D81720 Files: clang-tools-extra/clangd/Cod

[PATCH] D81720: [clangd] Change prepareCompilerInstance to take an FSProvider

2020-06-12 Thread Kadir Cetinkaya via Phabricator via cfe-commits
kadircet created this revision. kadircet added a reviewer: sammccall. Herald added subscribers: cfe-commits, usaxena95, arphaman, jkorous, MaskRay, ilya-biryukov. Herald added a project: clang. This makes API easier to use by moving setcwd and fscache setup into it. Also ensures no side effects a