[PATCH] D81958: [clangd] Add library to semantically strip flags by name.

ychen added inline comments. Comment at: clang-tools-extra/clangd/CompileCommands.cpp:356 + HELP, METAVAR, VALUES) \ + if (DriverID::OPT_##ALIAS != DriverID::OPT_INVALID && ALIASARGS == nullptr) \ +

[PATCH] D81958: [clangd] Add library to semantically strip flags by name.

sammccall marked an inline comment as done. sammccall added inline comments. Comment at: clang-tools-extra/clangd/CompileCommands.cpp:15 #include "clang/Tooling/ArgumentsAdjusters.h" +#include "llvm/Option/Option.h" +#include "llvm/Support/Allocator.h" daltenty

[PATCH] D81958: [clangd] Add library to semantically strip flags by name.

daltenty added inline comments. Comment at: clang-tools-extra/clangd/CompileCommands.cpp:15 #include "clang/Tooling/ArgumentsAdjusters.h" +#include "llvm/Option/Option.h" +#include "llvm/Support/Allocator.h" This breaks the powerpc64le bots. Looks like we

[PATCH] D81958: [clangd] Add library to semantically strip flags by name.

This revision was automatically updated to reflect the committed changes. sammccall marked an inline comment as done. Closed by commit rG8eb8c92eb469: [clangd] Add library to semantically strip flags by name. (authored by sammccall). Changed prior to commit:

[PATCH] D81958: [clangd] Add library to semantically strip flags by name.

hokein accepted this revision. hokein added a comment. still lg. Comment at: clang-tools-extra/clangd/unittests/CompileCommandsTests.cpp:197 +} + +TEST(ArgStripperTest, Spellings) { sammccall wrote: > hokein wrote: > > sammccall wrote: > > > hokein wrote: > >

[PATCH] D81958: [clangd] Add library to semantically strip flags by name.

sammccall updated this revision to Diff 277728. sammccall added a comment. Add more tests Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81958/new/ https://reviews.llvm.org/D81958 Files: clang-tools-extra/clangd/CompileCommands.cpp

[PATCH] D81958: [clangd] Add library to semantically strip flags by name.

sammccall marked an inline comment as done. sammccall added inline comments. Comment at: clang-tools-extra/clangd/unittests/CompileCommandsTests.cpp:197 +} + +TEST(ArgStripperTest, Spellings) { hokein wrote: > sammccall wrote: > > hokein wrote: > > > add tests

[PATCH] D81958: [clangd] Add library to semantically strip flags by name.

hokein accepted this revision. hokein added a comment. This revision is now accepted and ready to land. looks almost good. Comment at: clang-tools-extra/clangd/unittests/CompileCommandsTests.cpp:197 +} + +TEST(ArgStripperTest, Spellings) { sammccall wrote: >

[PATCH] D81958: [clangd] Add library to semantically strip flags by name.

sammccall updated this revision to Diff 277508. sammccall added a comment. Sigh, last upload was supposed to be a new patch, not clobber this one. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81958/new/ https://reviews.llvm.org/D81958 Files:

[PATCH] D81958: [clangd] Add library to semantically strip flags by name.

sammccall updated this revision to Diff 277507. sammccall added a comment. [clangd] Config: CompileFlags.Remove While here, add documentation to CompileFlags and CompileFlags.Add. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81958/new/

[PATCH] D81958: [clangd] Add library to semantically strip flags by name.

sammccall marked 2 inline comments as done. sammccall added a comment. OK, I think this is good to go now. Comment at: clang-tools-extra/clangd/CompileCommands.cpp:431 +continue; // current arg doesn't match the prefix string + bool PrefixMatch = Arg.size() >

[PATCH] D81958: [clangd] Add library to semantically strip flags by name.

sammccall updated this revision to Diff 277464. sammccall added a comment. Use explicit priority to resolve ambiguities between prefixes. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81958/new/ https://reviews.llvm.org/D81958 Files:

[PATCH] D81958: [clangd] Add library to semantically strip flags by name.

sammccall planned changes to this revision. sammccall added a comment. Need to work out how to address the order-dependency comment. Comment at: clang-tools-extra/clangd/CompileCommands.cpp:431 +continue; // current arg doesn't match the prefix string + bool

[PATCH] D81958: [clangd] Add library to semantically strip flags by name.

sammccall updated this revision to Diff 277444. sammccall marked 13 inline comments as done. sammccall added a comment. Address the easy comments, add a test for order-dependency. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81958/new/

[PATCH] D81958: [clangd] Add library to semantically strip flags by name.

hokein added inline comments. Comment at: clang-tools-extra/clangd/CompileCommands.cpp:263 +// Flag-parsing mode, which affects which flags are available. +enum DriverMode : unsigned char { + DM_None = 0, nit: put it into anonymous namespace to avoid potential

[PATCH] D81958: [clangd] Add library to semantically strip flags by name.

adamcz added inline comments. Comment at: clang-tools-extra/clangd/CompileCommands.cpp:256 + case Option::RemainingArgsClass: +return {1, 0}; + case Option::RemainingArgsJoinedClass: nit: could you replace 1 with some constant value with

[PATCH] D81958: [clangd] Add library to semantically strip flags by name.

sammccall created this revision. sammccall added reviewers: adamcz, hokein. Herald added subscribers: cfe-commits, usaxena95, kadircet, arphaman, jkorous, MaskRay, ilya-biryukov. Herald added a project: clang. This is designed for tweaking compile commands by specifying flags to add/remove in a