This revision was automatically updated to reflect the committed changes.
Closed by commit rG7f7f8564808b: Add `BoolLiteralExpression` to SyntaxTree
(authored by eduucaldas).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D82310/new/
gribozavr2 marked an inline comment as done.
gribozavr2 added inline comments.
Comment at: clang/unittests/Tooling/Syntax/TreeTest.cpp:1240
+ true;
+ false;
+}
eduucaldas wrote:
> gribozavr2 wrote:
> > eduucaldas wrote:
> > > gribozavr2 wrote:
> > > > C99 has
eduucaldas added inline comments.
Comment at: clang/unittests/Tooling/Syntax/TreeTest.cpp:1240
+ true;
+ false;
+}
gribozavr2 wrote:
> eduucaldas wrote:
> > gribozavr2 wrote:
> > > C99 has bool literals, but the program should include stdbool.h.
> > >
> > > I
eduucaldas updated this revision to Diff 273310.
eduucaldas marked 2 inline comments as done.
eduucaldas added a comment.
isC -> hasBoolType
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D82310/new/
https://reviews.llvm.org/D82310
Files:
gribozavr2 accepted this revision.
gribozavr2 marked an inline comment as done.
gribozavr2 added inline comments.
This revision is now accepted and ready to land.
Comment at: clang/unittests/Tooling/Syntax/TreeTest.cpp:1240
+ true;
+ false;
+}
eduucaldas
eduucaldas marked an inline comment as done.
eduucaldas added inline comments.
Comment at: clang/unittests/Tooling/Syntax/TreeTest.cpp:1240
+ true;
+ false;
+}
gribozavr2 wrote:
> C99 has bool literals, but the program should include stdbool.h.
>
> I feel
gribozavr2 added inline comments.
Comment at: clang/unittests/Tooling/Syntax/TreeTest.cpp:1240
+ true;
+ false;
+}
C99 has bool literals, but the program should include stdbool.h.
I feel like it is better to make the predicate something like "hasBoolType()"
eduucaldas marked 3 inline comments as done.
eduucaldas added inline comments.
Comment at: clang/include/clang/Tooling/Syntax/Nodes.h:268
+/// Expression for boolean literals. C++ [lex.bool]
+class BoolLiteralExpression final : public Expression {
Homogenize
eduucaldas created this revision.
Herald added a project: clang.
Herald added a subscriber: cfe-commits.
Repository:
rG LLVM Github Monorepo
https://reviews.llvm.org/D82310
Files:
clang/include/clang/Tooling/Syntax/Nodes.h
clang/lib/Tooling/Syntax/BuildTree.cpp
