[PATCH] D82312: Add `CharLiteral` to SyntaxTree

gribozavr2 added a comment. @vvereschaka Sorry about that. It looks like a bug in MSVC. I implemented a workaround in https://reviews.llvm.org/D82636 -- please review if you have time. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82312/new/

[PATCH] D82312: Add `CharLiteral` to SyntaxTree

eduucaldas added a comment. In D82312#2116028 , @vvereschaka wrote: > Hello Eduardo, > > sorry, but one of your these commits break the clang unit tests on the > following builders: > > -

[PATCH] D82312: Add `CharLiteral` to SyntaxTree

vvereschaka added a comment. Hello Eduardo, sorry, but one of your these commits break the clang unit tests on the following builders: - http://lab.llvm.org:8011/builders/llvm-clang-x86_64-win-fast/builds/18313 - http://lab.llvm.org:8011/builders/llvm-clang-win-x-aarch64/builds/256 -

[PATCH] D82312: Add `CharLiteral` to SyntaxTree

This revision was automatically updated to reflect the committed changes. Closed by commit rG221d7bbe49cc: Add `CharLiteral` to SyntaxTree (authored by eduucaldas). Changed prior to commit: https://reviews.llvm.org/D82312?vs=273343=273436#toc Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D82312: Add `CharLiteral` to SyntaxTree

eduucaldas updated this revision to Diff 273343. eduucaldas marked 3 inline comments as done. eduucaldas added a comment. Add tests for unicode characters Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82312/new/ https://reviews.llvm.org/D82312

[PATCH] D82312: Add `CharLiteral` to SyntaxTree

gribozavr2 accepted this revision. gribozavr2 added a comment. This revision is now accepted and ready to land. LGTM after new tests are added. Comment at: clang/unittests/Tooling/Syntax/TreeTest.cpp:1240 + 'a'; + L'a'; +} Could you add tests for escape

[PATCH] D82312: Add `CharLiteral` to SyntaxTree

eduucaldas marked 2 inline comments as done. eduucaldas added inline comments. Comment at: clang/unittests/Tooling/Syntax/TreeTest.cpp:1266 + +TEST_P(SyntaxTreeTest, CharacterLiteralCxx11) { + if (!GetParam().isCXX11OrLater()) { Rename to `CharacterLiteralUtf`?

[PATCH] D82312: Add `CharLiteral` to SyntaxTree

eduucaldas created this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. eduucaldas added a reviewer: gribozavr2. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D82312 Files: clang/include/clang/Tooling/Syntax/Nodes.h