[PATCH] D82398: [MSAN] Handle x86 {round,min,max}sd intrinsics

This revision was automatically updated to reflect the committed changes. guiand marked an inline comment as done. Closed by commit rGeae84b41fe8e: [MSAN] Handle x86 {round,min,max}sd intrinsics (authored by guiand). Changed prior to commit: https://reviews.llvm.org/D82398?vs=272855&id=273883#t

[PATCH] D82398: [MSAN] Handle x86 {round,min,max}sd intrinsics

eugenis accepted this revision. eugenis added a comment. This revision is now accepted and ready to land. LGTM Comment at: llvm/lib/Transforms/Instrumentation/MemorySanitizer.cpp:3077 +Value *LowShadow = IRB.CreateOr(LowA, LowB); +Value *Shadow = IRB.CreateInsertElement

[PATCH] D82398: [MSAN] Handle x86 {round,min,max}sd intrinsics

guiand updated this revision to Diff 272855. guiand added a comment. Addressed comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82398/new/ https://reviews.llvm.org/D82398 Files: llvm/lib/Transforms/Instrumentation/MemorySanitizer.cpp llv

[PATCH] D82398: [MSAN] Handle x86 {round,min,max}sd intrinsics

guiand marked 4 inline comments as done. guiand added inline comments. Comment at: llvm/lib/Transforms/Instrumentation/MemorySanitizer.cpp:3331 + // case Intrinsic::x86_avx512_mask_sub_sd_round: + // case Intrinsic::x86_avx512_mask_mul_sd_round: + // case Intrinsic

[PATCH] D82398: [MSAN] Handle x86 {round,min,max}sd intrinsics

eugenis added inline comments. Comment at: llvm/lib/Transforms/Instrumentation/MemorySanitizer.cpp:3077 +Value *LowShadow = IRB.CreateOr(LowA, LowB); +Value *Shadow = IRB.CreateInsertElement(Second, LowShadow, IRB.getInt32(0)); + guiand wrote: > eugenis

[PATCH] D82398: [MSAN] Handle x86 {round,min,max}sd intrinsics

guiand updated this revision to Diff 272842. guiand added a comment. Use shufflevector, move test over to IR Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82398/new/ https://reviews.llvm.org/D82398 Files: llvm/lib/Transforms/Instrumentation/Memo

[PATCH] D82398: [MSAN] Handle x86 {round,min,max}sd intrinsics

guiand marked an inline comment as done. guiand added inline comments. Comment at: llvm/lib/Transforms/Instrumentation/MemorySanitizer.cpp:3077 +Value *LowShadow = IRB.CreateOr(LowA, LowB); +Value *Shadow = IRB.CreateInsertElement(Second, LowShadow, IRB.getInt32(0)); + -

[PATCH] D82398: [MSAN] Handle x86 {round,min,max}sd intrinsics

eugenis added a comment. The test should be in LLVM, under test/Instrumentation/MemorySanitizer Comment at: llvm/lib/Transforms/Instrumentation/MemorySanitizer.cpp:3077 +Value *LowShadow = IRB.CreateOr(LowA, LowB); +Value *Shadow = IRB.CreateInsertElement(Second, LowSh

[PATCH] D82398: [MSAN] Handle x86 {round,min,max}sd intrinsics

guiand updated this revision to Diff 272776. guiand added a comment. Ran clang-format Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82398/new/ https://reviews.llvm.org/D82398 Files: clang/test/CodeGen/msan-intrinsics.c llvm/lib/Transforms/Inst

[PATCH] D82398: [MSAN] Handle x86 {round,min,max}sd intrinsics

guiand created this revision. guiand added a reviewer: eugenis. Herald added subscribers: llvm-commits, cfe-commits, hiraditya. Herald added projects: clang, LLVM. guiand updated this revision to Diff 272776. guiand added a comment. Ran clang-format These need special handling over the simple ve