[PATCH] D82415: [Coroutines] Special handle __builtin_coro_resume for final_suspend nothrow check

2020-06-25 Thread Xun Li via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. lxfind marked an inline comment as done. Closed by commit rG366159566df3: [Coroutines] Special handle __builtin_coro_resume for final_suspend nothrow… (authored by lxfind). Changed prior to commit:

[PATCH] D82415: [Coroutines] Special handle __builtin_coro_resume for final_suspend nothrow check

2020-06-25 Thread Lewis Baker via Phabricator via cfe-commits
lewissbaker accepted this revision. lewissbaker added a comment. This revision is now accepted and ready to land. LGTM Comment at: clang/lib/Sema/SemaCoroutine.cpp:621 +// returns a handle. In that case, even __builtin_coro_resume is not +// declared as

[PATCH] D82415: [Coroutines] Special handle __builtin_coro_resume for final_suspend nothrow check

2020-06-23 Thread Xun Li via Phabricator via cfe-commits
lxfind updated this revision to Diff 272910. lxfind added a comment. rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82415/new/ https://reviews.llvm.org/D82415 Files: clang/lib/Sema/SemaCoroutine.cpp Index:

[PATCH] D82415: [Coroutines] Special handle __builtin_coro_resume for final_suspend nothrow check

2020-06-23 Thread Xun Li via Phabricator via cfe-commits
lxfind updated this revision to Diff 272905. lxfind added a comment. Address lint Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82415/new/ https://reviews.llvm.org/D82415 Files: clang/lib/Sema/SemaCoroutine.cpp Index:

[PATCH] D82415: [Coroutines] Special handle __builtin_coro_resume for final_suspend nothrow check

2020-06-23 Thread Xun Li via Phabricator via cfe-commits
lxfind created this revision. Herald added subscribers: cfe-commits, modocache. Herald added a project: clang. lxfind added reviewers: modocache, lewissbaker, junparser. lxfind requested review of this revision. In https://reviews.llvm.org/D82029 we added the conformance check that the