[PATCH] D82448: [AArch64][SVE] Add bfloat16 support to store intrinsics

This revision was automatically updated to reflect the committed changes. Closed by commit rGedcfef8fee13: [AArch64][SVE] Add bfloat16 support to store intrinsics (authored by kmclaughlin). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82448/new/ ht

[PATCH] D82448: [AArch64][SVE] Add bfloat16 support to store intrinsics

fpetrogalli accepted this revision. fpetrogalli added a comment. This revision is now accepted and ready to land. LGTM, thank you! Comment at: clang/test/CodeGen/aarch64-sve-intrinsics/acle_sve_st1-bfloat.c:4 +// RUN: %clang_cc1 -D__ARM_FEATURE_SVE -D__ARM_FEATURE_BF16_SCALAR_A

[PATCH] D82448: [AArch64][SVE] Add bfloat16 support to store intrinsics

kmclaughlin marked 4 inline comments as done. kmclaughlin added a comment. Thanks for reviewing this again, @fpetrogalli! Comment at: clang/test/CodeGen/aarch64-sve-intrinsics/acle_sve_st1-bfloat.c:4 +// RUN: %clang_cc1 -D__ARM_FEATURE_SVE -D__ARM_FEATURE_BF16_SCALAR_ARITHMETIC

[PATCH] D82448: [AArch64][SVE] Add bfloat16 support to store intrinsics

kmclaughlin updated this revision to Diff 273331. kmclaughlin added a comment. - Added HasSVE to Predicates in AArch64SVEInstrInfo.td - Removed unnecessary indentation changes in AArch64SVEInstrInfo.td - Removed hasBF16 variable from performST1Combine/performSTNT1Combine CHANGES SINCE LAST ACTIO

[PATCH] D82448: [AArch64][SVE] Add bfloat16 support to store intrinsics

fpetrogalli requested changes to this revision. fpetrogalli added a comment. This revision now requires changes to proceed. Thank you for updating the patch with the missing tests. I only have one request for the code involving assertions, and the use of `let Predicates = ...`. Francesco ===

[PATCH] D82448: [AArch64][SVE] Add bfloat16 support to store intrinsics

kmclaughlin updated this revision to Diff 273092. kmclaughlin added a comment. - Added [HasBF16] predicate to new store pattern in AArch64SVEInstrInfo.td - Check hasBF16() is true for bfloat16 types in performST1Combine/performSTNT1Combine - Added bfloat16 test to sve-pred-contiguous-ldst-address

[PATCH] D82448: [AArch64][SVE] Add bfloat16 support to store intrinsics

fpetrogalli accepted this revision. fpetrogalli added a comment. This revision is now accepted and ready to land. LGTM, just one nit. Francesco Comment at: clang/test/CodeGen/aarch64-sve-intrinsics/acle_sve_st1-bfloat.c:4 +// RUN: %clang_cc1 -D__ARM_FEATURE_SVE -D__ARM_FEATURE

[PATCH] D82448: [AArch64][SVE] Add bfloat16 support to store intrinsics

kmclaughlin created this revision. kmclaughlin added reviewers: sdesmalen, c-rhodes, fpetrogalli, efriedma, stuij, david-arm. Herald added subscribers: llvm-commits, cfe-commits, danielkiss, psnobl, rkruppe, hiraditya, kristof.beyls, tschuett. Herald added projects: clang, LLVM. Bfloat16 support