This revision was automatically updated to reflect the committed changes.
Closed by commit rG74790a5dde9a: [PowerPC] Implement Truncate and Store VSX
Vector Builtins (authored by amyk).
Changed prior to commit:
https://reviews.llvm.org/D82467?vs=276881&id=280634#toc
Repository:
rG LLVM Githu
amyk added a comment.
The `llvm/test/CodeGen/PowerPC/builtins-ppc-p10vsx.ll` file actually exists,
and there is a BE RUN line in it. I realized I didn't rebase this diff to my
previous patch that introduced it. Thus on the commit, I will append my tests
to that file.
Repository:
rG LLVM Git
lei accepted this revision.
lei added a comment.
This revision is now accepted and ready to land.
LGTM,
Please add tests for BE in llvm/test/CodeGen/PowerPC/builtins-ppc-p10vsx.ll
prior to committing.
Comment at: llvm/test/CodeGen/PowerPC/builtins-ppc-p10vsx.ll:2
+; NOTE: Asse
stefanp accepted this revision as: stefanp.
stefanp added a comment.
LGTM.
Please wait for Lei to give the approval as well before you commit.
Comment at: llvm/test/CodeGen/PowerPC/builtins-ppc-p10vsx.ll:2
+; NOTE: Assertions have been autogenerated by utils/update_llc_test_ch
NeHuang added inline comments.
Comment at: llvm/test/CodeGen/PowerPC/builtins-ppc-p10vsx.ll:2
+; NOTE: Assertions have been autogenerated by utils/update_llc_test_checks.py
+; RUN: llc -verify-machineinstrs -mtriple=powerpc64le-unknown-linux-gnu \
+; RUN: -mcpu=pwr10 -ppc-asm-f
amyk updated this revision to Diff 276881.
amyk added a comment.
Rebased patch, and addressed review comments of having a single `CHECK`.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D82467/new/
https://reviews.llvm.org/D82467
Files:
clang/lib/H
lei added inline comments.
Comment at: clang/test/CodeGen/builtins-ppc-p10vector.c:108
+ signed char *__c) {
+ // CHECK-BE: store i8 %{{.+}}, i8* %{{.+}}, align 1
+ // CHECK-LE: store i8 %{{.+}}, i8* %{{.+}}, align 1
amyk wrote:
> lei
amyk marked an inline comment as done.
amyk added inline comments.
Comment at: clang/test/CodeGen/builtins-ppc-p10vector.c:108
+ signed char *__c) {
+ // CHECK-BE: store i8 %{{.+}}, i8* %{{.+}}, align 1
+ // CHECK-LE: store i8 %{{.+}}, i8* %{{.+}}, ali
lei requested changes to this revision.
lei added a comment.
This revision now requires changes to proceed.
Please move encoding tests to ppc64-encoding-ISA31.[txt|s].
Comment at: clang/test/CodeGen/builtins-ppc-p10vector.c:108
+ signed char *__c) {
+
amyk updated this revision to Diff 274672.
amyk added a comment.
Update the patch to place MC tests into appropriate files.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D82467/new/
https://reviews.llvm.org/D82467
Files:
clang/lib/Headers/altivec
amyk updated this revision to Diff 274260.
amyk added a comment.
Updated the patch to move the MC/llc tests into the appropriate files.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D82467/new/
https://reviews.llvm.org/D82467
Files:
clang/lib/Hea
amyk created this revision.
amyk added reviewers: power-llvm-team, PowerPC, saghir, nemanjai, hfinkel.
amyk added projects: LLVM, clang, PowerPC.
Herald added subscribers: shchenz, hiraditya.
This patch implements the following function prototypes for the truncate and
store VSX Vector instruction
12 matches
Mail list logo
